Skip to content

Deprecate louvain #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Deprecate louvain #3658

wants to merge 6 commits into from

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented May 28, 2025 •
edited
Loading

  • Release notes not necessary because:

@flying-sheep flying-sheep added this to the 1.12.0 milestone May 28, 2025
@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.14%. Comparing base (89780ec) to head (283bb9f).

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3658      +/-   ##
==========================================
- Coverage   76.14%   76.14%   -0.01%     
==========================================
  Files         114      114              
  Lines       12741    12452     -289     
==========================================
- Hits         9702     9481     -221     
+ Misses       3039     2971      -68
Files with missing lines Coverage Δ
src/scanpy/tools/_leiden.py 93.93% <ø> (+5.05%) ⬆️
src/scanpy/tools/_louvain.py 100.00% <100.00%> (+41.66%) ⬆️

... and 7 files with indirect coverage changes

@flying-sheep flying-sheep requested a review from ilan-gold May 28, 2025 13:26
ilan-gold
ilan-gold reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked issue suggests delaying louvain imports until later, can we do that as well?

@flying-sheep
Copy link
Member Author

flying-sheep commented May 28, 2025 •
edited
Loading

huh, I found a way to do it, but it looks weird!

@flying-sheep flying-sheep requested a review from ilan-gold May 28, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilan-gold ilan-gold Awaiting requested review from ilan-gold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Integration Testing CI Test Failure on python 3.12 Louvain package is deprecated in favor of leidenalg
2 participants
@flying-sheep @ilan-gold