Skip to content

Speed up wilcoxon rank-sum test with numba #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 28, 2025
Merged

Conversation

yxwucq
Copy link
Contributor

@yxwucq yxwucq commented Mar 27, 2025

Use njit to speed up sc.tl.rank_genes_groups(..., method='wilcoxon')

See #2390, #2060

@flying-sheep flying-sheep added this to the 1.11.1 milestone Mar 28, 2025
@flying-sheep flying-sheep changed the title njit parallel computing wilcoxon rank-sum test Speed up wilcoxon rank-sum test with numba Mar 28, 2025
Copy link

scverse-benchmark bot commented Mar 28, 2025

Benchmark changes

Change Before [30de733] After [3991e3a] Ratio Benchmark (Parameter)
- 2.17±0.2ms 1.68±0.02ms 0.78 preprocessing_counts.FastSuite.time_normalize_total('bmmc', 'counts')
+ 24.7±0.4ms 32.0±0.5ms 1.29 preprocessing_counts.FastSuite.time_normalize_total('pbmc3k', 'counts-off-axis')
- 89.5±1ms 59.6±4ms 0.67 tools.time_rank_genes_groups

Comparison: https://github.com/scverse/scanpy/compare/30de73326f8d617488f8e64bb14ef5c09d748c15..3991e3afa2e8c8f1b8d6a2bbac3e0014ea9ca2cc
Last changed: Fri, 28 Mar 2025 14:46:58 +0000

More details: https://github.com/scverse/scanpy/pull/3529/checks?check_run_id=39588624031

@flying-sheep flying-sheep self-assigned this Mar 28, 2025
@flying-sheep flying-sheep merged commit fd53492 into scverse:main Mar 28, 2025
14 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Mar 28, 2025
flying-sheep pushed a commit that referenced this pull request Mar 28, 2025
Co-authored-by: George Wu <59241797+yxwucq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants