Skip to content

Conversation

@ori-kron-wis
Copy link
Collaborator

@ori-kron-wis ori-kron-wis commented Dec 8, 2025

need to wait for anndata, mudata, scanpy updates

@ori-kron-wis ori-kron-wis self-assigned this Dec 8, 2025
@ori-kron-wis ori-kron-wis added on-merge: backport to 1.4.x on-merge: backport to 1.4.x autotune private tests Run private tests custom_dataloader PR 2932 optional tests Run optional tests internet tests Run internet tests multiGPU tests Run test suite on Multi GPU CUDA workstation nonJAX mlflow labels Dec 8, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ori-kron-wis ori-kron-wis added cuda tests Run test suite on CUDA and removed multiGPU tests Run test suite on Multi GPU CUDA workstation labels Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.46%. Comparing base (04787b9) to head (7c0ea11).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
+ Coverage   86.62%   88.46%   +1.83%     
==========================================
  Files         226      226              
  Lines       21859    21859              
==========================================
+ Hits        18936    19338     +402     
+ Misses       2923     2521     -402     

see 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis
Copy link
Collaborator Author

also mlflow is not yet supported with pandas3

@ori-kron-wis
Copy link
Collaborator Author

We will have to remove all pip install git+https://github.com/scverse/anndata appears in the yaml of test once anndata is released as well as the changes in pyproject (will not need to pin anything)

@ori-kron-wis ori-kron-wis merged commit f35ae71 into main Jan 28, 2026
20 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Jan 28, 2026
ori-kron-wis added a commit that referenced this pull request Jan 28, 2026
Backport PR #3638: refactor: pandas3 support

Co-authored-by: Ori Kronfeld <ori.kronfeld@weizmann.ac.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autotune cuda tests Run test suite on CUDA custom_dataloader PR 2932 internet tests Run internet tests mlflow nonJAX on-merge: backport to 1.4.x on-merge: backport to 1.4.x optional tests Run optional tests private tests Run private tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant