Skip to content

Inequality CAG errors out if data contains NaN values #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2025

Conversation

R-Palazzo
Copy link
Contributor

CU-86b4u4gbf
Resolve #2488

@R-Palazzo R-Palazzo requested review from frances-h and fealho May 7, 2025 11:36
@R-Palazzo R-Palazzo self-assigned this May 7, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner May 7, 2025 11:36
@sdv-team
Copy link
Contributor

sdv-team commented May 7, 2025

@R-Palazzo R-Palazzo removed the request for review from a team May 7, 2025 11:36
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (db6409b) to head (f1864df).
Report is 1 commits behind head on feature/single-table-CAG.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feature/single-table-CAG    #2507   +/-   ##
=========================================================
  Coverage                     98.54%   98.54%           
=========================================================
  Files                            68       68           
  Lines                          6993     6997    +4     
=========================================================
+ Hits                           6891     6895    +4     
  Misses                          102      102           
Flag Coverage Δ
integration 83.45% <100.00%> (+<0.01%) ⬆️
unit 97.15% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an integration test with the code snippet provided in the issue?

@R-Palazzo R-Palazzo force-pushed the issue-2488-inequality-nan branch from e866f5c to f1864df Compare May 8, 2025 12:00
@R-Palazzo R-Palazzo merged commit e454c68 into feature/single-table-CAG May 8, 2025
45 checks passed
@R-Palazzo R-Palazzo deleted the issue-2488-inequality-nan branch May 8, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants