Skip to content

Splash screen autogenerated - splash-bg.png + splash-icon.png #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alfreddagenais opened this issue Jul 18, 2020 · 5 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@alfreddagenais
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not related to a problem

Add labels
enhancement

Describe the solution you'd like
In photography we work with the tier 1/3 ( Composition and rule of thirds ). Normally in this generator we provide the splash.png and the system generate a composition of images with this master template. With my tests I could notice the rule of thirds is not always obtained. It's not a big deal, but for my eyes I would have a better look and feel.

So this is why my ideas came. Can we have a generator we can take a background apply to a Splash screen first. Divide the screen in 9 parts. Apply the splash Icon in the middle max width or max height to respect the image ratio for each screen generated?

What do you think?

Describe alternatives you've considered
I do not think any alternative solutions for this at this moment.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label enhancement to this issue, with a confidence of 0.60. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the enhancement New feature or request label Jul 18, 2020
@alfreddagenais
Copy link
Contributor Author

Issue-Label Bot is automatically applying the label enhancement to this issue, with a confidence of 0.60. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

👍

@sebinbenjamin
Copy link
Owner

That seems to be a cool feature! Please do add an expected splash with the background image and icon, just to make sure the feature is clear. PRs always welcome.

I'm in the middle of refactoring parts of the codebase. I'm not sure if I can look into this immediately. Thanks

@sebinbenjamin sebinbenjamin added the help wanted Extra attention is needed label Jul 19, 2020
@alfreddagenais
Copy link
Contributor Author

alfreddagenais commented Jul 19, 2020

I'm not sure what is your request exactly, I understand you need to view an expected splash background image and icon. So check the next pictures. The aqua line is simple to represent the rule of thirds in images.

My example is for the generated resource : resources/ios/splash/Default@2x~iphone.png

Ressource Generated :
Ressource Generated

Expected image with rule of thirds :
Expected image

The red circle represents the area available for the splash-icon.png


This is a possiblity of settings to place logo in correct zone of the thirds

left column center column right column
(7) left-top (8) center-top (9) right-top
(4) left-center (5) center-center (6) right-center
(1) left-bottom (2) center-bottom (3) right-bottom

This options is base on CSS background-position Property
The first value is the horizontal position and the second value is the vertical.

For the number is simply a fast-way to position the Icon based on Numpad schemas
Numpad image

In other version we could add a possibility to add percentage to position at the desired position.


@sebinbenjamin Just be sure on which git branche you work for your refactoring? I would try to do a PR in the good branche 👍 Thank you

@sebinbenjamin
Copy link
Owner

Hey, the PRs are against develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants