Skip to content

Conversation

@DicksonWu654
Copy link
Collaborator

@DicksonWu654 DicksonWu654 commented Oct 21, 2025

Frameworks PR Checklist

Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:

  • This is the other half of the baby of Multisig for Protocols #239
  • If you are touching an existing piece of content, tag current contributors from the attribution list
  • If there is a steward for that framework, ask the steward to review it
  • If you're modifying the general outline, make sure to update it in the vocs.config.ts adding the dev: true parameter
  • If you need feedback for your content from the wider community, share the PR in our Discord
  • Review changes to ensure there are no typos, see instructions below

- Introduced a new section for Multisig, including links to Overview, Signing & Verification, Private Key & Seed Phrase Management, and Tools & Resources.
- Enhanced navigation structure to improve user access to multisig-related content.
- Updated navigation links to reflect new structure for the Multisig section.
- Added detailed subsections including General Rules, Multisig Administration, and For Signers with specific links for better user guidance.
- Improved overall organization to facilitate easier access to multisig-related content.
- Enhanced the Multisig for Protocols section by adding detailed subsections and improving navigation links for better user experience.
- Updated links in various documents to ensure consistency and accessibility, including links to related topics such as Emergency Procedures, General Rules, and Hardware Wallet Setup.
- Added frontmatter tags and contributor information to relevant documents for better categorization and attribution.
- Corrected links in offboarding, ongoing management, planning and classification, and setup and configuration documents to ensure they point to the correct sections.
- Enhanced clarity and accessibility of documentation by standardizing link formats.
- Updated the formatting of "Safe{Wallet}" to "Safe\{Wallet\}" for consistency across the backup infrastructure and signing when UI is down documentation.
- Ensured uniformity in documentation presentation to enhance clarity.
- Updated the financial exposure thresholds in the planning and classification section to use escape characters for less than and greater than symbols for improved clarity.
- Ensured consistent formatting across the documentation to enhance readability and maintain standards.
- Replaced local image paths with direct links to hosted images for better accessibility and consistency across the documentation.
- Removed obsolete image files to streamline the asset management.
- Added new contributor profiles for Isaac Patka, Geoffrey Arone, Louis Marquenet, and Pablo Sabbatella, including their roles, company affiliations, and social media links.
- Enhanced the contributors.json file to reflect the expanded contributor base and improve attribution in documentation.
…tion

- Reformatted the list of prohibited practices for better clarity and emphasis.
- Ensured consistent presentation of security guidelines to enhance user understanding.
…mplementation Checklist'

- Changed references in the vocs.config.ts, general-rules.mdx, and overview.mdx files to reflect the new 'Implementation Checklist' terminology.
- Deleted the outdated 'training-checklist.mdx' file to streamline documentation and avoid confusion.
- Updated the profiles of Geoffrey Arone, Louis Marquenet, and Pablo Sabbatella to set their GitHub and Twitter links to null, reflecting a change in their social media presence.
- Ensured the contributors.json file remains accurate and up-to-date for proper attribution in documentation.
…w documentation

- Deleted the Emergency Contacts subsection to streamline the content and focus on essential information.
- Ensured the overview remains concise and relevant for users seeking guidance on multisig operations.
…tation

- Updated the Quick Start section to provide clearer guidance for new users, including direct links to relevant subsections for setup, signing, and emergency procedures.
- Enhanced the structure to improve navigation and accessibility of essential information for multisig operations.
…view documentation

- Revised the reference to minimum security standards to include a direct link for better accessibility.
- Ensured clarity in the core principles section to enhance user understanding of security requirements.
…isig documentation

- Adjusted the order of entries in the use case table for better logical flow and readability.
- Ensured that the table maintains clarity in presenting impact, operational needs, and standard thresholds for multisig operations.
…fication section of Multisig documentation. Ensured consistent presentation to enhance clarity and readability for users.
…ion to direct users to the Registration & Documentation page for improved navigation and clarity.
…on by replacing the detailed template with a direct link to the new template location in the Registration & Documentation page, enhancing user navigation and clarity.
…ocumentation in the multisig for protocols guide to streamline content and focus on essential classification guidance.
…anning and classification documentation by specifying higher thresholds for upgrades (7/9+), enhancing guidance for users on operational assessments.
…protocols to enhance clarity and readability.
…uidance

- Removed the 'Seed Phrase Security' page and integrated its content into the 'Private Key Management' section for improved clarity and accessibility.
- Updated links across various documentation pages to reflect the new structure, ensuring users are directed to the consolidated guidance on seed phrase and private key management.
- Enhanced the overall organization of multisig protocols documentation to streamline user navigation and understanding.
…ith 'Seed Phrase Management'

- Renamed all instances of 'Private Key & Seed Phrase Management' to 'Seed Phrase Management' across various documentation pages for consistency and clarity.
- Removed the 'private-key-management.mdx' file as its content has been integrated into the updated structure, streamlining the documentation for wallet security.
- Updated links in the multisig protocols documentation to direct users to the new seed phrase management guidance.
…d signatures

- Included additional steps for users to publish verified signatures on Etherscan, improving the clarity of the verification process.
- Emphasized the importance of entering plain text messages and ensuring the signature includes the 0x prefix for successful verification.
- Added 'pinalikefruit' as a reviewer alongside 'dickson' in multiple documentation pages to enhance the review process and ensure comprehensive oversight.
- This change applies to various sections including administration, backup infrastructure, communication setup, and more, improving the collaborative aspect of documentation maintenance.
…ences

- Removed the 'Backup Infrastructure' section and replaced it with 'Backup Signing & Infrastructure' across multiple documentation pages for clarity and consistency.
- Deleted the outdated 'backup-infrastructure.mdx' and 'signing-when-ui-is-down.mdx' files, consolidating their content into the new structure.
- Updated links and checklist items to reflect the new terminology, ensuring users have access to the most relevant and accurate information regarding backup procedures.
- Deleted the 'Ongoing Management' page and integrated its content into the 'Registration & Documentation' section for improved clarity and organization.
- Updated references across multiple documentation pages to reflect this change, ensuring users have access to consolidated management procedures.
- Enhanced the overall structure of the documentation to streamline user navigation and understanding.
…erences with 'Use Case Specific Requirements → Timelock Configuration'

- Removed direct links to the 'Timelock Configuration' page and updated them to point to the relevant section within 'Use Case Specific Requirements' for better context and navigation.
- Enhanced clarity by adding a dedicated 'Timelock Configuration' section within the 'Use Case Specific Requirements' page, providing detailed guidance on its implementation and considerations.
- Updated multiple documentation pages to reflect these changes, ensuring consistency and improved user experience.
- Removed duplicate 'Registration & Documentation' entry for clarity and conciseness.
- Deleted the 'Backup Signing & Infrastructure' link to simplify the overview and focus on essential topics.
- Updated the structure of the overview section to enhance user navigation and understanding of multisig protocols.
- Removed empty 'Overview' entries in the table of contents for 'Multisig Administration' and 'For Signers' sections to enhance readability.
- Updated links in various sections to provide clearer references, such as changing 'Section 2.3' to 'Signer Rotation' and 'Section 2.1' to 'Thresholds & Configuration'.
- Streamlined documentation by ensuring consistent terminology and improving user guidance throughout the multisig protocols.
… guidance

- Added a note regarding the maintenance status of local/alternative UIs, emphasizing their use as emergency options.
- Included links to the Safe Android app and its availability on major app stores for user convenience.
- Expanded the section on network explorers by providing a broader list of options for transaction exploration, improving user access to resources.
- Introduced a new guideline recommending the use of a separate browser or profile for signing to enhance security during transaction verification.
…emove outdated references

- Introduced new sections for 'Safe Multisig: Step-by-Step Verification' and 'Squads Multisig: Step-by-Step Verification' to provide detailed guidance on transaction verification.
- Updated links throughout the documentation to replace references to the deleted 'Transaction Verification & Signing' page, ensuring users have access to current verification resources.
- Enhanced clarity by adding key definitions related to EVM transaction verification and emphasizing best practices for multisig signing processes.
- Removed outdated content and streamlined references to improve navigation and user experience across the documentation.
…ferences and enhance security guidance

- Deleted the 'General Rules' page and replaced references throughout the documentation with links to 'Secure Multisig Best Practices' for improved clarity and consistency.
- Updated various sections to ensure all links point to the new best practices resource, enhancing user access to current security guidelines.
- Streamlined documentation by removing redundant content and ensuring all references align with the latest security protocols.
…ed formatting

- Reformatted import statements for consistency and readability.
- Added access options for 'Eternal Safe' and 'Squads Public Client' with GitHub links for user convenience.
- Improved clarity by adjusting formatting in various sections, including the use of italics for emphasis.
- Updated fetched tags to include relevant categories for new documentation sections, ensuring accurate tagging and improved resource organization.
…ed clarity

- Added 'dev: true' flags to various sections and items in the multisig documentation to indicate development status.
- Updated links for 'Safe Multisig' and 'Squads Multisig' verification processes to reflect their development status.
- Enhanced the 'Multisig for Protocols' section by marking all items as development-related, improving clarity for users regarding the current state of the documentation.
…and verification processes

- Added detailed signing guidelines emphasizing the use of hardware wallets, secure environments, and communication protocols among signers.
- Expanded sections on transaction verification for both SOL and USDS transfers, including step-by-step instructions and example interpretations of instruction data.
- Improved clarity by restructuring content and adding links to relevant transaction simulation tools and resources.
- Updated the signing process documentation to reinforce best practices and ensure signers are well-informed before executing transactions.
- Updated the travel considerations section to improve clarity by removing emoji indicators and presenting the information in a straightforward list format.
- Enhanced the organization of what to bring and what not to bring, ensuring users have clear and concise travel security recommendations.
…criptions

- Centered the image for the Eternal Safe network selection and added a descriptive caption to enhance user understanding.
- Improved visual presentation of the setup instructions for better clarity and engagement.
@vercel
Copy link

vercel bot commented Oct 21, 2025

@DicksonWu654 is attempting to deploy a commit to the Security Alliance Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
frameworks Ready Ready Preview Comment Oct 23, 2025 11:02am

@pinalikefruit
Copy link
Collaborator

Hi @DicksonWu654 ,

I think this PR should only show the changes for the Wallet security section, but the Multisig Protocol was also added, adjust that and I'll start with the review.

@DicksonWu654
Copy link
Collaborator Author

Hey @pinalikefruit yeah this shows the full diff... Hmm maybe i pointed it to the wrong branch to merge or smth. Lol I'm not the best at git tbh. But it should resolve itself when the first half of the child is merged 🙏

But you can still see the diff via: 5ec0994

Copy link
Collaborator

@pinalikefruit pinalikefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DicksonWu654 I hope you find well, thanks again for your contribution and your work.

Few adjustments and ready to merge

@DicksonWu654
Copy link
Collaborator Author

@pinalikefruit just resolved all the comments + I merged the hardware wallet content like you asked in #239 in this commit: DicksonWu654@c9fa073

@DicksonWu654
Copy link
Collaborator Author

Hopefully it looks good

… link with intermediates & medium funds section, enhancing resource organization.
Comment on lines +61 to +69
## Recommended Devices

**Ledger:**
- Ledger Stax
- Ledger Nano S Plus

**Trezor:**
- Trezor Model One
- Trezor Safe 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing; we do not provide a specific recommendation for a specific brand of product. We provide specifications or tools such as https://frameworks.securityalliance.org/wallet-security/tools-&-resources#wallet-selection so that the user can make their choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants