Skip to content

Commit ec8e63a

Browse files
authored
Merge pull request #214 from sendbird/fix/camera-permission
fix: revert android camera permission
2 parents 0473ec0 + c5db2a2 commit ec8e63a

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

packages/uikit-react-native/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,12 @@ Add the following permissions to your `android/app/src/main/AndroidManifest.xml`
7979
<!-- Permissions for voice message -->
8080
<uses-permission android:name="android.permission.RECORD_AUDIO" />
8181

82-
<!-- Permissions for image attachments -->
82+
<!-- Permissions for attachments -->
8383
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32" />
8484
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="28" />
85+
<uses-permission android:name="android.permission.CAMERA" />
8586

86-
<!-- Permissions for notifications (Android 13) -->
87+
<!-- Permissions for notifications (Android 13+) -->
8788
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
8889

8990
</manifest>

packages/uikit-react-native/src/platform/createFileService.native.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ const createNativeFileService = ({
5959
}): FileServiceInterface => {
6060
const cameraPermissions: Permission[] = Platform.select({
6161
ios: [permissionModule.PERMISSIONS.IOS.CAMERA, permissionModule.PERMISSIONS.IOS.MICROPHONE],
62-
android: [],
62+
android: [permissionModule.PERMISSIONS.ANDROID.CAMERA],
6363
default: [],
6464
});
6565
const mediaLibraryPermissions: Permission[] = Platform.select({

sample/android/app/src/main/AndroidManifest.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@
88
<!-- Permissions for voice message -->
99
<uses-permission android:name="android.permission.RECORD_AUDIO" />
1010

11-
<!-- Permissions for image attachments -->
11+
<!-- Permissions for attachments -->
1212
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32" />
1313
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="28" />
14+
<uses-permission android:name="android.permission.CAMERA" />
1415

15-
<!-- Permissions for notifications (Android 13) -->
16+
<!-- Permissions for notifications (Android 13+) -->
1617
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
1718

1819
<application

0 commit comments

Comments
 (0)