Skip to content

Conversation

CoRfr
Copy link

@CoRfr CoRfr commented Jul 15, 2019

Pull Request Checklist

Is this in reference to an existing issue?

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

This script, very similar to metrics-interface.rb, allows to collect
metrics on remote host by SSH.

This is meant to be able to collect metrics on host that cannot
necessarily run sensu client, such as small routers for instance.

Known Compatibility Issues

This script, very similar to metrics-interface.rb, allows to collect
metrics on remote host by SSH.

This is meant to be able to collect metrics on host that cannot
necessarily run sensu client, such as small routers for instance.
@CoRfr CoRfr force-pushed the metrics-interface-ssh branch from c158644 to ec154fa Compare July 15, 2019 04:19
Copy link
Contributor

@jindraj jindraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created pull #115. Would you consider similar changes in your code to be consistent since it does the same?

@CoRfr
Copy link
Author

CoRfr commented Oct 9, 2019

Do you mean adding excludeinterfaceregex/includeinterfaceregex ?

@jindraj
Copy link
Contributor

jindraj commented Oct 9, 2019

Do you mean adding excludeinterfaceregex/includeinterfaceregex ?

thank you

@jspaleta
Copy link
Contributor

Hey,
Can you take a look and see if this PR is still relevant. If it is can you rebase against master so we can get the travisCI happy?

If this is not still needed, please close.

@CoRfr
Copy link
Author

CoRfr commented Jan 19, 2020

@jspaleta , I would think it's still relevant so I merged the master branch into this commit to update it, and resolved conflicts accordingly.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants