Skip to content

Update subtype from 'imagedata' to 'datacube' #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emmanuelmathot
Copy link
Collaborator

This fixes #57

@vincentsarago
Copy link
Collaborator

vincentsarago commented Mar 3, 2025

@emmanuelmathot I don't think it's as simple as just renaming the type

Right now we have datacube being a RasterStack https://github.com/sentinel-hub/titiler-openeo/blob/main/titiler/openeo/processes/implementations/data_model.py#L11. ImageData is one element of the datacube.

if we take the apply_pixel_selection process, it would not work on a ImageData but only Stack, I'm not quite sure what to do.

It seems that we could play with the dimensions https://github.com/Open-EO/openeo-processes/blob/6141771129d58d2a292db3b91d80c812c49f4e52/ndvi.json#L11-L30, maybe an ImageData is a bands of a data cube 🤷 (again I feel openeo as assets as band baked in, which is not always the case)

👀 https://github.com/Open-EO/openeo-processes/blob/master/meta/implementation.md#data-cubes

@emmanuelmathot emmanuelmathot mentioned this pull request Mar 13, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the naming of the data objects with openEO specifications
2 participants