Skip to content

Feature/482 http video #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 12, 2024
Merged

Feature/482 http video #483

merged 16 commits into from
Oct 12, 2024

Conversation

sentinelweb
Copy link
Owner

@sentinelweb sentinelweb commented Oct 7, 2024 •
edited
Loading

implements #482

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 7, 2024
View reviewed changes
app/src/main/java/uk/co/sentinelweb/cuer/app/ui/ytplayer/AytViewHolder.kt
log.d("PlayerCommand.Load: $_currentVideoId != ${command.platformId} start:${command.startPosition}")
if (_currentVideoId != command.platformId) {
_player?.loadVideo(command.platformId, command.startPosition / 1000f)
log.d("PlayerCommand.Load: $_currentVideoId != ${command.item.media.platformId} start:${command.startPosition}")

Check warning

Code scanning / detekt

Line detected that is longer than the defined maximum line length in the code style. Warning

Line detected that is longer than the defined maximum line length in the code style.
app/src/main/java/uk/co/sentinelweb/cuer/app/ui/ytplayer/AytViewHolder.kt
_player?.loadVideo(command.platformId, command.startPosition / 1000f)
log.d("PlayerCommand.Load: $_currentVideoId != ${command.item.media.platformId} start:${command.startPosition}")
if (_currentVideoId != command.item.media.platformId) {
_player?.loadVideo(command.item.media.platformId, command.startPosition / 1000f)

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.
remote/src/jvmAndAndroid/kotlin/uk/co/sentinelweb/cuer/remote/server/JvmRemoteWebServer.kt
import io.ktor.server.request.*
import io.ktor.server.response.*
import io.ktor.server.routing.*
import io.ktor.utils.io.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

io.ktor.utils.io.* is a wildcard import. Replace it with fully qualified imports.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 7, 2024
View reviewed changes
app/src/main/java/uk/co/sentinelweb/cuer/app/ui/remotes/RemotesFragment.kt
is CuerSelectSendTo ->
remotesDialogLauncher.launchRemotesDialog(
{ remoteNodeDomain, screen ->
remotesMviView.dispatch(Event.OnActionSendToSelected(value.sendNode, remoteNodeDomain))

Check warning

Code scanning / detekt

Line detected that is longer than the defined maximum line length in the code style. Warning

Line detected that is longer than the defined maximum line length in the code style.
net/src/commonMain/kotlin/uk/co/sentinelweb/cuer/net/remote/RemoteStatusKtorInteractor.kt
NetResult.Data(true)
} catch (e: RequestFailureException) {
NetResult.HttpError(e)
} catch (e: Exception) {

Check warning

Code scanning / detekt

Caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled. Warning

Caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/remotes/RemotesStoreFactory.kt
import uk.co.sentinelweb.cuer.remote.server.message.AvailableMessage.MsgType.Ping

class RemotesStoreFactory constructor(
class RemotesStoreFactory(

Check warning

Code scanning / detekt

The more parameters a function has the more complex it is. Long parameter lists are often used to control complex algorithms and violate the Single Responsibility Principle. Prefer functions with short parameter lists. Warning

The constructor(storeFactory: StoreFactory, log: LogWrapper, remoteServerManager: RemoteServerContract.Manager, coroutines: CoroutineContextProvider, localRepository: LocalRepository, remoteStatusInteractor: RemoteStatusInteractor, remotesRepository: RemotesRepository, locationPermissionLaunch: LocationPermissionLaunch, wifiStateProvider: WifiStateProvider, getPlaylistsFromDeviceUseCase: GetPlaylistsFromDeviceUseCase, castController: CastController) has too many parameters. The current threshold is set to 7.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 7, 2024
View reviewed changes
...n/kotlin/uk/co/sentinelweb/cuer/hub/ui/remotes/selector/RemotesDialogLauncherComposeables.kt
Dialog(onDismissRequest = { remotesDialogLauncher.hideRemotesDialog() }) {
Surface(
shape = MaterialTheme.shapes.medium,
elevation = 24.dp

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 11, 2024
View reviewed changes
remote/src/jvmAndAndroid/kotlin/uk/co/sentinelweb/cuer/remote/server/JvmRemoteWebServer.kt
import org.koin.core.component.inject
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source.LOCAL
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source.* is a wildcard import. Replace it with fully qualified imports.
shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/usecase/PlaylistMediaUpdateUsecase.kt
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source.LOCAL
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source.MEMORY
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source.* is a wildcard import. Replace it with fully qualified imports.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 12, 2024
View reviewed changes
domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/domain/ext/ChannelDomainExt.kt
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Identifier.Locator
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source.REMOTE
import uk.co.sentinelweb.cuer.domain.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

uk.co.sentinelweb.cuer.domain.* is a wildcard import. Replace it with fully qualified imports.
domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/domain/ext/MediaDomainExt.kt
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Identifier.Locator
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source
import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Source.REMOTE
import uk.co.sentinelweb.cuer.domain.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

uk.co.sentinelweb.cuer.domain.* is a wildcard import. Replace it with fully qualified imports.
remote/src/jvmAndAndroid/kotlin/uk/co/sentinelweb/cuer/remote/server/JvmRemoteWebServer.kt
import uk.co.sentinelweb.cuer.app.usecase.GetFolderListUseCase
import uk.co.sentinelweb.cuer.core.providers.PlayerConfigProvider
import uk.co.sentinelweb.cuer.core.wrapper.LogWrapper
import uk.co.sentinelweb.cuer.domain.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

uk.co.sentinelweb.cuer.domain.* is a wildcard import. Replace it with fully qualified imports.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 12, 2024
View reviewed changes
domain/src/iosMain/kotlin/uk/co/sentinelweb/cuer/core/wrapper/URLEncoder.kt
@@ -0,0 +1,15 @@
package uk.co.sentinelweb.cuer.core.wrapper

import platform.Foundation.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

platform.Foundation.* is a wildcard import. Replace it with fully qualified imports.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 12, 2024
View reviewed changes
domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/remote/server/RemoteWebServerContract.kt
const val PATH = "/folders"
const val P_PARAM = "p"
}
object VIDEO_STREAM_API {

Check warning

Code scanning / detekt

A class or object's name should fit the naming pattern defined in the projects configuration. Warning

Class and Object names should match the pattern: [A-Z][a-zA-Z0-9]*
@sentinelweb sentinelweb merged commit f74e211 into develop Oct 12, 2024
4 checks passed
@sentinelweb sentinelweb deleted the feature/482-http-video branch October 12, 2024 16:06
@sentinelweb sentinelweb linked an issue Oct 12, 2024 that may be closed by this pull request
play video file over network #482
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

play video file over network
1 participant
@sentinelweb