From f5a05a69cfb5da011f9cd72b153c427e6ca1471b Mon Sep 17 00:00:00 2001
From: sentinelweb <robmunro@robs-MacBook-Pro.local>
Date: Sat, 28 Jun 2025 11:53:29 +0200
Subject: [PATCH 1/7] #496 - refactor FilesViewModel.kt

---
 .../app/ui/filebrowser/FileBrowserFragment.kt |  14 +-
 .../hub/ui/filebrowser/FilesUiCoordinator.kt  |  11 +-
 .../ui/common/viewmodel/ViewModelEffects.kt   |  22 ++
 .../app/ui/filebrowser/FilesComposeables.kt   |  18 +-
 .../cuer/app/ui/filebrowser/FilesContract.kt  |  21 +-
 .../app/ui/filebrowser/FilesModelMapper.kt    |   3 +-
 .../cuer/app/ui/filebrowser/FilesViewModel.kt | 202 +++++++++++-------
 7 files changed, 178 insertions(+), 113 deletions(-)
 create mode 100644 shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/common/viewmodel/ViewModelEffects.kt

diff --git a/app/src/main/java/uk/co/sentinelweb/cuer/app/ui/filebrowser/FileBrowserFragment.kt b/app/src/main/java/uk/co/sentinelweb/cuer/app/ui/filebrowser/FileBrowserFragment.kt
index b6f49dadc..96712544f 100644
--- a/app/src/main/java/uk/co/sentinelweb/cuer/app/ui/filebrowser/FileBrowserFragment.kt
+++ b/app/src/main/java/uk/co/sentinelweb/cuer/app/ui/filebrowser/FileBrowserFragment.kt
@@ -19,7 +19,7 @@ import uk.co.sentinelweb.cuer.app.ui.common.ktx.bindFlow
 import uk.co.sentinelweb.cuer.app.ui.common.navigation.*
 import uk.co.sentinelweb.cuer.app.ui.common.navigation.NavigationModel.Param.BACK_PARAMS
 import uk.co.sentinelweb.cuer.app.ui.common.navigation.NavigationModel.Target.NAV_BACK
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Label
+import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect
 import uk.co.sentinelweb.cuer.app.ui.play_control.CompactPlayerScroll
 import uk.co.sentinelweb.cuer.app.ui.player.PlayerContract
 import uk.co.sentinelweb.cuer.app.util.extension.fragmentScopeWithSource
@@ -90,18 +90,18 @@ class FileBrowserFragment : Fragment(), AndroidScopeComponent {
             )
         }
         statusBarColor.setStatusBarColorResource(R.color.black)
-        bindFlow(viewModel.labels, ::observeLabels)
+        bindFlow(viewModel.effects, ::observeLabels)
         remoteIdArg?.apply { viewModel.init(this, filePathArg) }
     }
 
-    private fun observeLabels(label: Label) {
+    private fun observeLabels(label: Effect) {
         when (label) {
-            Label.Init -> {}
-            Label.Up -> {
+            Effect.Init -> {}
+            Effect.Up -> {
                 navRouter.navigate(NavigationModel(NAV_BACK, mapOf(BACK_PARAMS to R.id.navigation_remotes)))
             }
 
-            Label.Settings -> navigationProvider.navigate(R.id.navigation_settings_root)
+            Effect.Settings -> navigationProvider.navigate(R.id.navigation_settings_root)
             else -> Unit
         }
     }
@@ -135,7 +135,7 @@ class FileBrowserFragment : Fragment(), AndroidScopeComponent {
             scope(named<FileBrowserFragment>()) {
                 viewModel {
                     FilesViewModel(
-                        state = FilesContract.State(),
+                        initialState = FilesContract.State(),
                         filesInteractor = get(),
                         remotesRepository = get(),
                         mapper = get(),
diff --git a/hub/src/main/kotlin/uk/co/sentinelweb/cuer/hub/ui/filebrowser/FilesUiCoordinator.kt b/hub/src/main/kotlin/uk/co/sentinelweb/cuer/hub/ui/filebrowser/FilesUiCoordinator.kt
index f6a90cb85..9a2b938d9 100644
--- a/hub/src/main/kotlin/uk/co/sentinelweb/cuer/hub/ui/filebrowser/FilesUiCoordinator.kt
+++ b/hub/src/main/kotlin/uk/co/sentinelweb/cuer/hub/ui/filebrowser/FilesUiCoordinator.kt
@@ -1,9 +1,12 @@
 package uk.co.sentinelweb.cuer.hub.ui.filebrowser
 
 import androidx.compose.runtime.Composable
-import kotlinx.coroutines.*
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.SupervisorJob
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.collectLatest
+import kotlinx.coroutines.launch
 import org.koin.core.component.KoinComponent
 import org.koin.core.qualifier.named
 import org.koin.core.scope.Scope
@@ -11,7 +14,7 @@ import org.koin.dsl.module
 import uk.co.sentinelweb.cuer.app.ui.cast.CastController
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesComposeables.FileBrowserDesktopUi
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Label.ErrorMessage
+import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect.ErrorMessage
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Model.Companion.Initial
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.State
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesViewModel
@@ -52,7 +55,7 @@ class FilesUiCoordinator(
 
     private fun bindLabels() {
         coordinatorScope.launch {
-            viewModel.labels.collectLatest {
+            viewModel.effects.collectLatest {
                 when (it) {
                     is ErrorMessage -> parent.showError(it.message)
                     else -> Unit
@@ -82,7 +85,7 @@ class FilesUiCoordinator(
             scope(named<FilesUiCoordinator>()) {
                 scoped {
                     FilesViewModel(
-                        state = State(),
+                        initialState = State(),
                         filesInteractor = get(),
                         remotesRepository = get(),
                         mapper = get(),
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/common/viewmodel/ViewModelEffects.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/common/viewmodel/ViewModelEffects.kt
new file mode 100644
index 000000000..b18f83a1b
--- /dev/null
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/common/viewmodel/ViewModelEffects.kt
@@ -0,0 +1,22 @@
+package uk.co.sentinelweb.cuer.app.ui.common.viewmodel
+
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.channels.BufferOverflow
+import kotlinx.coroutines.flow.Flow
+import kotlinx.coroutines.flow.MutableSharedFlow
+import kotlinx.coroutines.launch
+
+class ViewModelEffects<Effect> {
+
+    private val _effects = MutableSharedFlow<Effect>(
+        replay = 0,
+        extraBufferCapacity = 1,
+        onBufferOverflow = BufferOverflow.DROP_OLDEST
+    )
+    val labels: Flow<Effect> = _effects
+
+    fun emit(label: Effect, scope: CoroutineScope) =
+        scope.launch {
+            _effects.emit(label)
+        }
+}
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
index c5721e088..0e24e517f 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
@@ -23,8 +23,8 @@ import uk.co.sentinelweb.cuer.app.ui.common.compose.CuerSharedAppBarComposables.
 import uk.co.sentinelweb.cuer.app.ui.common.compose.CuerSharedTheme
 import uk.co.sentinelweb.cuer.app.ui.common.compose.CustomSnackbar
 import uk.co.sentinelweb.cuer.app.ui.common.compose.colorTransparentYellow
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Label
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Label.None
+import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect
+import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect.None
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.ListItem.ListItemType.*
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Model.Companion.Initial
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.Alpha
@@ -40,12 +40,12 @@ object FilesComposeables {
     fun FileBrowserAppUi(viewModel: FilesContract.ViewModel) {
         val model = viewModel.modelObservable.collectAsState(initial = Initial)
         val snackbarHostState = remember { SnackbarHostState() }
-        val label = viewModel.labels.collectAsState(initial = None)
+        val effects = viewModel.effects.collectAsState(initial = None)
 
-        LaunchedEffect(label.value) {
-            when (label.value) {
-                is Label.ErrorMessage -> snackbarHostState.showSnackbar(
-                    message = (label.value as Label.ErrorMessage).message,
+        LaunchedEffect(effects.value) {
+            when (effects.value) {
+                is Effect.ErrorMessage -> snackbarHostState.showSnackbar(
+                    message = (effects.value as Effect.ErrorMessage).message,
                 )
 
                 else -> Unit
@@ -222,14 +222,14 @@ object FilesComposeables {
                                 text = text,
                                 style = MaterialTheme.typography.bodyMedium,
                                 color = MaterialTheme.colorScheme.onSurface,
-                                modifier = Modifier.padding(4.dp).align(Alignment.CenterVertically)
+                                modifier = Modifier.padding(4.dp).align(CenterVertically)
                             )
                         }
                         Text(
                             text = listItem.timeSince,
                             style = MaterialTheme.typography.bodySmall,
                             color = Color.Gray,
-                            modifier = Modifier.padding(2.dp).align(Alignment.CenterVertically)
+                            modifier = Modifier.padding(2.dp).align(CenterVertically)
                         )
                     }
                 }
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
index 7df8c42de..06407369a 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
@@ -11,7 +11,7 @@ interface FilesContract {
 
     interface ViewModel {
         val modelObservable: Flow<Model>
-        val labels: Flow<Label>
+        val effects: Flow<Effect>
 
         fun onClickFolder(folder: PlaylistDomain)
 
@@ -35,10 +35,9 @@ interface FilesContract {
         var upListItem: Pair<ListItem, PlaylistDomain>? = null,
         var selectedFile: PlaylistItemDomain? = null,
         var sort: Sort = Sort.Alpha,
-        var sortAcending: Boolean = false
-    ) {
-
-    }
+        var sortAcending: Boolean = false,
+        var loading: Boolean = true,
+    )
 
     enum class Sort { Alpha, Time }
 
@@ -72,15 +71,15 @@ interface FilesContract {
         }
     }
 
-    sealed class Label {
-        object None : Label()
-        object Init : Label()
-        object Up : Label()
-        object Settings : Label()
+    sealed class Effect {
+        object None : Effect()
+        object Init : Effect()
+        object Up : Effect()
+        object Settings : Effect()
         data class ErrorMessage(
             val message: String,
             val unique: Int = Random.nextInt()
-        ) : Label()
+        ) : Effect()
     }
 
     companion object {
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt
index 9390a3dee..5ef39b6e0 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt
@@ -19,9 +19,8 @@ class FilesModelMapper(
 
     fun map(
         state: FilesContract.State,
-        loading: Boolean,
     ) = FilesContract.Model(
-        loading = loading,
+        loading = state.loading,
         nodeName = state.sourceNode?.name(),
         filePath = state.path?.let { "/$it" },
         upListItem = state.upListItem,
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
index b7ce06b4a..138da0b80 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
@@ -2,17 +2,14 @@ package uk.co.sentinelweb.cuer.app.ui.filebrowser
 
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
-import kotlinx.coroutines.delay
-import kotlinx.coroutines.flow.Flow
-import kotlinx.coroutines.flow.MutableStateFlow
+import kotlinx.coroutines.flow.*
 import kotlinx.coroutines.launch
 import org.jetbrains.compose.resources.getString
 import uk.co.sentinelweb.cuer.app.ui.cast.CastController
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Label
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Label.ErrorMessage
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Label.None
+import uk.co.sentinelweb.cuer.app.ui.common.viewmodel.ViewModelEffects
+import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect
+import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect.ErrorMessage
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Model
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Model.Companion.Initial
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.Alpha
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.Time
 import uk.co.sentinelweb.cuer.app.ui.player.PlayerContract
@@ -34,8 +31,10 @@ import uk.co.sentinelweb.cuer.shared.generated.resources.Res
 import uk.co.sentinelweb.cuer.shared.generated.resources.files_error_empty
 import uk.co.sentinelweb.cuer.shared.generated.resources.files_error_loading_folder
 
+typealias StateUpdater = (FilesContract.State) -> FilesContract.State
+
 class FilesViewModel(
-    private val state: FilesContract.State,
+    initialState: FilesContract.State,
     private val filesInteractor: RemoteFilesInteractor,
     private val remotesRepository: RemotesRepository,
     private val mapper: FilesModelMapper,
@@ -48,13 +47,15 @@ class FilesViewModel(
     private val localRepository: LocalRepository,
     private val localPlayerLaunchHost: PlayerLaunchHost,
     private val localPlayerStatus: PlayerContract.LocalStatus,
+    private val _effects: ViewModelEffects<Effect> = ViewModelEffects(),
 ) : ViewModel(), FilesContract.ViewModel {
 
-    private val _modelObservable = MutableStateFlow(Initial)
-    override val modelObservable: Flow<Model> = _modelObservable
+    private val _stateObservable = MutableStateFlow(initialState)
+    override val modelObservable: Flow<Model> = _stateObservable
+        .map { mapper.map(it) }
 
-    private val _labels = MutableStateFlow<Label>(None)
-    override val labels: Flow<Label> = _labels
+    override val effects: Flow<Effect>
+        get() = _effects.labels
 
     init {
         log.tag(this)
@@ -62,33 +63,41 @@ class FilesViewModel(
 
     // fixme: used by app could make remoteId=null for local
     override fun init(remoteId: GUID, path: String?) {
-        resetState()
-        state.sourceRemoteId = remoteId
-        state.sourceNode = remotesRepository.getById(remoteId)
-        state.path = path
-        loadCurrentPath()
+        init(remotesRepository.getById(remoteId), path)
     }
 
     override fun init(node: NodeDomain?, path: String?) {
-        resetState()
-        state.sourceNode = node ?: localRepository.localNode
-        state.path = path
-        loadCurrentPath()
+        loadCurrentPath({ it: FilesContract.State ->
+            it.copy(
+                sourceNode = node ?: localRepository.localNode,
+                path = path,
+                upListItem = null,
+                currentFolder = null,
+                currentListItems = null,
+                selectedFile = null,
+                sourceRemoteId = null,
+            )
+        })
     }
 
+
     override fun onBackClick() {
-        state.upListItem
+        _stateObservable.value.upListItem
             ?.also { onClickFolder(it.second) }
-            ?: run { _labels.value = Label.Up }
+            ?: run { _effects.emit(Effect.Up, viewModelScope) }
     }
 
     override fun onUpClick() {
-        _labels.value = Label.Up
+        _effects.emit(Effect.Up, viewModelScope)
     }
 
     override fun onClickFolder(folder: PlaylistDomain) {
-        state.path = folder.platformId
-        loadCurrentPath()
+        log.d("onClickFolder: ${folder.title}")
+        loadCurrentPath({
+            it.copy(
+                path = folder.platformId
+            )
+        })
     }
 
     override fun onClickFile(file: PlaylistItemDomain) {
@@ -103,34 +112,41 @@ class FilesViewModel(
         loadCurrentPath()
     }
 
-    override fun onSort(type: FilesContract.Sort) {
+    private fun sortParams(
+        currentState: FilesContract.State,
+        type: FilesContract.Sort
+    ): Pair<Boolean, FilesContract.Sort> =
         when (type) {
             Alpha -> {
-                state.sortAcending = if (state.sort == Alpha) !state.sortAcending else true
-                state.sort = Alpha
+                (if (currentState.sort == Alpha) !currentState.sortAcending else true) to Alpha
             }
 
             Time -> {
-                state.sortAcending = if (state.sort == Time) !state.sortAcending else false
-                state.sort = Time
+                (if (currentState.sort == Time) !currentState.sortAcending else false) to Time
             }
         }
-        map(false)
+
+    override fun onSort(type: FilesContract.Sort) {
+        _stateObservable.update { lastState ->
+            val sortParams = sortParams(lastState, type)
+            lastState.copy(
+                sort = sortParams.second,
+                sortAcending = sortParams.first,
+                loading = false
+            )
+        }
     }
 
     override fun onSettings() {
-        viewModelScope.launch {
-            _labels.value = Label.Settings
-            delay(1)
-            _labels.value = None
-        }
+        _effects.emit(Effect.Settings, viewModelScope)
     }
 
     private fun playMedia(file: PlaylistItemDomain) {
-        state.selectedFile = file
+        val newState = _stateObservable.updateAndGet { state ->
+            state.copy(selectedFile = file, loading = true)
+        }
         viewModelScope.launch {
-            map(true)
-            state.sourceNode?.apply {
+            newState.sourceNode?.apply {
                 if (localPlayerStatus.isPlayerActive()) {
                     launchLocalPlayer(null, null, file)
                 } else if (cuerCastPlayerWatcher.isWatching()) {
@@ -152,7 +168,14 @@ class FilesViewModel(
                     })
                 }
             }
-            map(false)
+            setLoadingState(false)
+        }
+    }
+
+    private fun setLoadingState(isLoading: Boolean) {
+        _stateObservable.update { lastState ->
+            lastState
+                .copy(loading = isLoading)
         }
     }
 
@@ -171,35 +194,48 @@ class FilesViewModel(
         targetNode: RemoteNodeDomain, screen: PlayerNodeDomain.Screen
     ) {
         viewModelScope.launch {
-            map(true)
+            setLoadingState(true)
             playerInteractor.launchPlayerVideo(
                 targetNode.locator(),
-                state.selectedFile ?: throw IllegalStateException(),
+                _stateObservable.value.selectedFile ?: throw IllegalStateException(),
                 screen.index
             )
             if (!castController.isConnected()) {
                 castController.connectCuerCast(targetNode, screen)
             }
             remoteDialogLauncher.hideRemotesDialog()
-            map(false)
+            setLoadingState(false)
         }
     }
 
-    private fun loadCurrentPath() = viewModelScope.launch {
-        map(true)
-        state.sourceNode?.apply {
+    private fun loadCurrentPath(updater: StateUpdater? = null) = viewModelScope.launch {
+        //setLoadingState(true, updater)// how to wait foir this to update
+        val newState = _stateObservable.updateAndGet { state ->
+            val updatedState = updater?.invoke(state) ?: state
+            updatedState.copy(loading = true)
+        }
+        log.d("loadSource: ${newState.sourceNode}")
+        log.d("loadCurrentPath: ${newState.path}")
+        // fixme this isnt getting the right node as it out of sync
+        newState.sourceNode?.apply {
             val folder = when (this) {
                 is RemoteNodeDomain ->
-                    filesInteractor.getFolderList(this.locator(), state.path)
+                    filesInteractor.getFolderList(this.locator(), newState.path)
                         .let {
-                            log.d(it.data.toString())
                             when (it) {
-                                is NetResult.Data -> it.data
+                                is NetResult.Data -> it.data.also {
+                                    log.d("data: ${it?.playlist?.title} (${it?.children?.size}) children: ${it?.children?.map { it.title }}")
+                                }
+
                                 is NetResult.Error -> {
-                                    _labels.value = ErrorMessage(
-                                        getString(
-                                            Res.string.files_error_loading_folder, it.code ?: "", it.msg ?: ""
-                                        )
+                                    _effects.emit(
+                                        label = ErrorMessage(
+                                            getString(
+                                                Res.string.files_error_loading_folder,
+                                                it.code ?: "",
+                                                it.msg ?: ""
+                                            )
+                                        ), scope = viewModelScope
                                     )
                                     null
                                 }
@@ -207,10 +243,12 @@ class FilesViewModel(
                         }
 
                 is LocalNodeDomain -> try {
-                    getFolderListUseCase.getFolderList(state.path)
+                    getFolderListUseCase.getFolderList(newState.path)
                 } catch (e: Exception) {
-                    _labels.value =
-                        ErrorMessage(getString(Res.string.files_error_loading_folder, "", e.message ?: ""))
+                    _effects.emit(
+                        ErrorMessage(getString(Res.string.files_error_loading_folder, "", e.message ?: "")),
+                        viewModelScope
+                    )
                     null
                 }
 
@@ -219,37 +257,41 @@ class FilesViewModel(
 
             folder
                 ?.takeIf { it.children.isEmpty() && it.playlist.items.isEmpty() }
-                ?.also { _labels.value = ErrorMessage(getString(Res.string.files_error_empty)) }
+                ?.also {
+                    _effects.emit(
+                        ErrorMessage(getString(Res.string.files_error_empty)),
+                        viewModelScope
+                    )
+                }
 
             folder
                 ?.takeIf { it.children.isNotEmpty() || it.playlist.items.isNotEmpty() }
                 ?.also { folderOk ->
                     val upItem = folderOk.children.find { PARENT_FOLDER_TEXT.equals(it.title) }
-                    state.upListItem = upItem?.let { mapper.mapParentItem(it) }
-                    state.currentFolder =
-                        folderOk.copy(children = upItem?.let { folderOk.children.minus(it) } ?: folderOk.children)
+                        .also { log.d("update: ${folderOk.children.size} items") }
+                    _stateObservable.updateAndGet {
+                        val newFolder = folderOk.copy(
+                            children = upItem?.let { folderOk.children.minus(it) } ?: folderOk.children
+                        )
 
-                    state.currentListItems = state.currentFolder?.let { mapper.mapToIntermediate(it) }
+                        it.copy(
+                            upListItem = upItem?.let { mapper.mapParentItem(it) },
+                            currentFolder = newFolder,
+                            currentListItems = mapper.mapToIntermediate(newFolder),  // Use the NEW folder
+                            loading = false
+                        )
+
+                    }.also { log.d("loadComplete: ${it.currentListItems?.size} items") }
                 } ?: also {
-                state.upListItem = null
-                state.currentFolder = null
-                state.currentListItems = null
+                _stateObservable.updateAndGet {
+                    it.copy(
+                        upListItem = null,
+                        currentFolder = null,
+                        currentListItems = null,
+                        loading = false
+                    )
+                }
             }
         }
-        map(false)
-    }
-
-    private fun map(loading: Boolean) {
-        _modelObservable.value = mapper.map(state = state, loading = loading)
-    }
-
-    private fun resetState() {
-        state.upListItem = null
-        state.currentFolder = null
-        state.currentListItems = null
-        state.selectedFile = null
-        state.sourceRemoteId = null
-        state.sourceNode = null
-        state.path = null
     }
 }

From 0b205b17818ab6db70a2e2ecdd0466ef32036b97 Mon Sep 17 00:00:00 2001
From: sentinelweb <robmunro@robs-MacBook-Pro.local>
Date: Sat, 28 Jun 2025 12:47:51 +0200
Subject: [PATCH 2/7] #496 - add sort by episode

---
 .../composeResources/drawable/ic_episode.xml  | 48 +++++++++++++++++++
 .../composeResources/values/strings.xml       |  1 +
 .../compose/CuerSharedAppBarComposables.kt    |  4 +-
 .../app/ui/filebrowser/FilesComposeables.kt   | 12 ++---
 .../cuer/app/ui/filebrowser/FilesContract.kt  |  4 +-
 .../app/ui/filebrowser/FilesModelMapper.kt    | 19 +++++---
 .../cuer/app/ui/filebrowser/FilesViewModel.kt | 14 +-----
 7 files changed, 74 insertions(+), 28 deletions(-)
 create mode 100644 shared/src/commonMain/composeResources/drawable/ic_episode.xml

diff --git a/shared/src/commonMain/composeResources/drawable/ic_episode.xml b/shared/src/commonMain/composeResources/drawable/ic_episode.xml
new file mode 100644
index 000000000..a021b4dd0
--- /dev/null
+++ b/shared/src/commonMain/composeResources/drawable/ic_episode.xml
@@ -0,0 +1,48 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+        android:width="24dp"
+        android:height="24dp"
+        android:viewportWidth="24"
+        android:viewportHeight="24"
+        android:tint="#fffff">
+
+    <!-- TV Frame -->
+    <path
+            android:fillColor="#fffff"
+            android:pathData="M21,3H3C1.9,3 1,3.9 1,5v12c0,1.1 0.9,2 2,2h5v1c0,0.55 0.45,1 1,1h6c0.55,0 1,-0.45 1,-1v-1h5c1.1,0 2,-0.9 2,-2V5c0,-1.1 -0.9,-2 -2,-2z"/>
+
+    <!-- Screen with Episode Number -->
+    <path
+            android:fillColor="#000000"
+            android:pathData="M4,6h16v10h-16z"/>
+
+    <!-- Episode marker - "E01" text -->
+    <path
+            android:fillColor="#fffff"
+            android:pathData="M7.5,11h1v-4h-1z"/>
+    <path
+            android:fillColor="#fffff"
+            android:pathData="M7,8.5h2v-1h-2z"/>
+    <path
+            android:fillColor="#fffff"
+            android:pathData="M7,11h2v-1h-2z"/>
+
+    <!-- 0 in E01 -->
+    <path
+            android:fillColor="#fffff"
+            android:pathData="M10,8.5c-0.55,0 -1,0.45 -1,1v1c0,0.55 0.45,1 1,1s1,-0.45 1,-1v-1c0,-0.55 -0.45,-1 -1,-1z M10,10.5c-0.28,0 -0.5,-0.22 -0.5,-0.5s0.22,-0.5 0.5,-0.5 0.5,0.22 0.5,0.5 -0.22,0.5 -0.5,0.5z"/>
+
+    <!-- 1 in E01 -->
+    <path
+            android:fillColor="#fffff"
+            android:pathData="M12.5,11h1v-2.5h-0.5l-0.5,0.5h-0.5v-1l1,-0.5h0.5v3.5z"/>
+
+    <!-- Timeline marker -->
+    <path
+            android:fillColor="#fffff"
+            android:pathData="M5,13h14v1h-14z"/>
+
+    <!-- Playback dot -->
+    <path
+            android:fillColor="#fffff"
+            android:pathData="M8,13.5m-0.5,0a0.5,0.5 0,1 1,1 0a0.5,0.5 0,1 1,-1 0"/>
+</vector>
diff --git a/shared/src/commonMain/composeResources/values/strings.xml b/shared/src/commonMain/composeResources/values/strings.xml
index 5a97e42a8..9fd39b0d3 100644
--- a/shared/src/commonMain/composeResources/values/strings.xml
+++ b/shared/src/commonMain/composeResources/values/strings.xml
@@ -11,6 +11,7 @@
     <string name="menu_sort_alpha">Alphabetical</string>
     <string name="menu_sort_category">Categories</string>
     <string name="menu_sort_time">Time</string>
+    <string name="menu_sort_episode">Episode</string>
     <string name="menu_delete">Delete</string>
     <string name="menu_edit">Edit</string>
     <string name="menu_move">Move</string>
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/common/compose/CuerSharedAppBarComposables.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/common/compose/CuerSharedAppBarComposables.kt
index c07729e34..c64f5ea4e 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/common/compose/CuerSharedAppBarComposables.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/common/compose/CuerSharedAppBarComposables.kt
@@ -87,7 +87,7 @@ object CuerSharedAppBarComposables {
     ) {
         actions.forEach { Action(it, contentColor) }
         overflow?.also {
-            TopAppBarOverflowMenu(it, contentColor)
+            TopAppBarOverflowMenu(it)
         }
     }
 
@@ -121,6 +121,7 @@ sealed class CuerMenuItem(
     object SortAlpha : CuerMenuItem(Res.string.menu_sort_alpha, Res.drawable.ic_sort_by_alpha)
     object SortCategory : CuerMenuItem(Res.string.menu_sort_category, Res.drawable.ic_category)
     object SortTime : CuerMenuItem(Res.string.menu_sort_time, Res.drawable.ic_sort_time)
+    object SortEpisode : CuerMenuItem(Res.string.menu_sort_episode, Res.drawable.ic_episode)
 
     object Folders : CuerMenuItem(Res.string.menu_folders, Res.drawable.ic_folder)
     object ThemeTest : CuerMenuItem(Res.string.menu_theme_test, Res.drawable.ic_edit)
@@ -157,6 +158,7 @@ fun TopAppBarOverflowMenu(
                     Icon(
                         painter = painterResource(action.item.icon),
                         contentDescription = null,
+                        tint = contentColor,
                         modifier = Modifier
                             .clickable {
                                 expanded = false
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
index 0e24e517f..0a10bd3cc 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
@@ -27,8 +27,7 @@ import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect.None
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.ListItem.ListItemType.*
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Model.Companion.Initial
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.Alpha
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.Time
+import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.*
 import uk.co.sentinelweb.cuer.domain.Domain
 import uk.co.sentinelweb.cuer.domain.PlaylistDomain
 import uk.co.sentinelweb.cuer.domain.PlaylistItemDomain
@@ -75,13 +74,14 @@ object FilesComposeables {
                             backgroundColor = colorTransparentYellow,
                             onUp = { viewModel.onUpClick() },
                             actions = listOf(
-                                Action(SortAlpha, { viewModel.onSort(Alpha) }),
-                                Action(SortTime, { viewModel.onSort(Time) }),
                                 Action(item = Reload, action = { viewModel.onRefreshClick() }),
                             ),
                             overflowActions = listOf(
-                                Action(Help, { }),
+                                Action(SortAlpha, { viewModel.onSort(Alpha) }),
+                                Action(SortTime, { viewModel.onSort(Time) }),
+                                Action(SortEpisode, { viewModel.onSort(Episode) }),
                                 Action(Settings, { viewModel.onSettings() }),
+                                Action(Help, { }),
                             ),
                             modifier = Modifier.fillMaxSize().align(Alignment.CenterStart)
                         )
@@ -216,7 +216,7 @@ object FilesComposeables {
 
                 if (listItem.timeSince != null) {
                     Row(Modifier.fillMaxWidth()) {
-                        val text = "${listItem.season ?: ""} ${listItem.ext ?: ""}".trim()
+                        val text = "${listItem.episodeNumber ?: ""} ${listItem.ext ?: ""}".trim()
                         if (text.isNotBlank()) {
                             Text(
                                 text = text,
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
index 06407369a..6c11b114c 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
@@ -39,7 +39,7 @@ interface FilesContract {
         var loading: Boolean = true,
     )
 
-    enum class Sort { Alpha, Time }
+    enum class Sort { Alpha, Time, Episode }
 
     @Serializable
     data class ListItem(
@@ -49,7 +49,7 @@ interface FilesContract {
         val tags: List<String>,
         val type: ListItemType,
         val ext: String? = null,
-        val season: String? = null,
+        val episodeNumber: String? = null,
         val timeSince: String? = null,
     ) {
         @Serializable
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt
index 5ef39b6e0..a713c3028 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt
@@ -2,8 +2,7 @@ package uk.co.sentinelweb.cuer.app.ui.filebrowser
 
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.ListItem
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.ListItem.ListItemType.*
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.Alpha
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.Time
+import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.*
 import uk.co.sentinelweb.cuer.app.usecase.GetFolderListUseCase.Companion.PARENT_FOLDER_TEXT
 import uk.co.sentinelweb.cuer.core.mappers.TimeSinceFormatter
 import uk.co.sentinelweb.cuer.domain.Domain
@@ -30,12 +29,18 @@ class FilesModelMapper(
                 if (state.sortAcending) {
                     when (state.sort) {
                         Time -> compareBy({ it.key.dateModified })
-                        Alpha -> compareBy({ it.key.title.lowercase() })
+                        Alpha -> compareBy<Map.Entry<ListItem, *>>({ it.key.title.lowercase() })
+                            .thenBy { it.key.episodeNumber?.lowercase() ?: "" }
+
+                        Episode -> compareBy({ it.key.episodeNumber?.lowercase() })
                     }
                 } else {
                     when (state.sort) {
                         Time -> compareByDescending({ it.key.dateModified })
-                        Alpha -> compareByDescending({ it.key.title.lowercase() })
+                        Alpha -> compareByDescending<Map.Entry<ListItem, *>>({ it.key.title.lowercase() })
+                            .thenBy { it.key.episodeNumber?.lowercase() ?: "" }
+
+                        Episode -> compareByDescending({ it.key.episodeNumber?.lowercase() })
                     }
                 }
             )
@@ -54,8 +59,8 @@ class FilesModelMapper(
             f.media.title
                 ?.takeIf { it != ".DS_Store" }
                 ?.let {
-                mapFileItem(it, f)
-            }
+                    mapFileItem(it, f)
+                }
         }).toMap()
 
     fun mapFileItem(
@@ -134,7 +139,7 @@ class FilesModelMapper(
             tags = tags,
             type = FILE,
             ext = ext,
-            season = season,
+            episodeNumber = season,
         )
     }
 }
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
index 138da0b80..b28034d8d 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
@@ -10,8 +10,6 @@ import uk.co.sentinelweb.cuer.app.ui.common.viewmodel.ViewModelEffects
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Effect.ErrorMessage
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Model
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.Alpha
-import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.Time
 import uk.co.sentinelweb.cuer.app.ui.player.PlayerContract
 import uk.co.sentinelweb.cuer.app.ui.remotes.selector.NodesDialogContract
 import uk.co.sentinelweb.cuer.app.usecase.GetFolderListUseCase
@@ -115,16 +113,8 @@ class FilesViewModel(
     private fun sortParams(
         currentState: FilesContract.State,
         type: FilesContract.Sort
-    ): Pair<Boolean, FilesContract.Sort> =
-        when (type) {
-            Alpha -> {
-                (if (currentState.sort == Alpha) !currentState.sortAcending else true) to Alpha
-            }
-
-            Time -> {
-                (if (currentState.sort == Time) !currentState.sortAcending else false) to Time
-            }
-        }
+    ): Pair<Boolean, FilesContract.Sort> = (
+            if (currentState.sort == type) !currentState.sortAcending else true) to type
 
     override fun onSort(type: FilesContract.Sort) {
         _stateObservable.update { lastState ->

From b905879acadff97c4b3111587f3fde55b010d24d Mon Sep 17 00:00:00 2001
From: sentinelweb <robmunro@robs-MacBook-Pro.local>
Date: Sat, 28 Jun 2025 13:57:26 +0200
Subject: [PATCH 3/7] #496 - add file sizes

---
 .../cuer/core/mappers/FileSizeMapper.kt       | 27 ++++++
 .../cuer/core/mappers/FileSizeMapperTest.kt   | 23 +++++
 .../cuer/core/mappers/ExpectedMappers.kt      |  4 +
 .../uk/co/sentinelweb/cuer/di/DomainModule.kt |  4 +-
 .../co/sentinelweb/cuer/domain/MediaDomain.kt |  1 +
 .../cuer/core/mappers/FileSizeMapper.kt       |  7 ++
 .../cuer/core/mappers/FileSizeMapper.kt       |  7 ++
 .../cuer/core/mappers/FileSizeMapper.kt       | 28 ++++++
 .../app/ui/filebrowser/FilesComposeables.kt   | 88 ++++++++++++++++---
 .../cuer/app/ui/filebrowser/FilesContract.kt  |  4 +-
 .../app/ui/filebrowser/FilesModelMapper.kt    | 10 ++-
 .../cuer/app/ui/filebrowser/FilesViewModel.kt |  4 +-
 .../cuer/app/usecase/GetFolderListUseCase.kt  |  1 +
 13 files changed, 190 insertions(+), 18 deletions(-)
 create mode 100644 domain/src/androidMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
 create mode 100644 domain/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapperTest.kt
 create mode 100644 domain/src/iosMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
 create mode 100644 domain/src/jsMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
 create mode 100644 domain/src/jvmMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt

diff --git a/domain/src/androidMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt b/domain/src/androidMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
new file mode 100644
index 000000000..cbf8914a0
--- /dev/null
+++ b/domain/src/androidMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
@@ -0,0 +1,27 @@
+package uk.co.sentinelweb.cuer.core.mappers
+
+actual class FileSizeMapper {
+    actual fun formatFileSize(sizeBytes: Long): String =
+        formatFileSize(bytes = sizeBytes)
+}
+
+/**
+ * Formats file size in bytes to a human-readable string with appropriate unit (G, M, K).
+ * @param bytes The file size in bytes
+ * @param decimalPlaces Number of decimal places to include (default: 1)
+ * @return Formatted string representation of the file size
+ */
+fun formatFileSize(bytes: Long, decimalPlaces: Int = 1): String {
+    if (bytes <= 0) return "-"
+
+    val units = arrayOf("", "K", "M", "G", "T")
+    val digitGroups = (Math.log10(bytes.toDouble()) / Math.log10(1024.0)).toInt()
+
+    val format = if (decimalPlaces > 0) "%.${decimalPlaces}f %s" else "%.0f %s"
+
+    return String.format(
+        format,
+        bytes / Math.pow(1024.0, digitGroups.toDouble()),
+        units[digitGroups.coerceAtMost(units.size - 1)]
+    ).trim()
+}
diff --git a/domain/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapperTest.kt b/domain/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapperTest.kt
new file mode 100644
index 000000000..e90a96e84
--- /dev/null
+++ b/domain/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapperTest.kt
@@ -0,0 +1,23 @@
+package uk.co.sentinelweb.cuer.core.mappers
+
+import org.junit.Assert.assertEquals
+import org.junit.Before
+import org.junit.Test
+
+class FileSizeMapperTest {
+    private val sut = FileSizeMapper()
+
+    @Before
+    fun setUp() {
+
+    }
+
+    @Test
+    fun formatFileSize() {
+        assertEquals("1.0", sut.formatFileSize(1))
+        assertEquals("1.0 K", sut.formatFileSize(1024))
+        assertEquals("1.0 M", sut.formatFileSize(1024 * 1024))
+        assertEquals("1.0 G", sut.formatFileSize(1024 * 1024 * 1024))
+    }
+
+}
diff --git a/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/ExpectedMappers.kt b/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/ExpectedMappers.kt
index 039a7db6a..70ad66245 100644
--- a/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/ExpectedMappers.kt
+++ b/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/ExpectedMappers.kt
@@ -20,6 +20,10 @@ expect class DateTimeFormatter() {
     fun formatDateTimeNullable(dateTime: LocalDateTime?): String
 }
 
+expect class FileSizeMapper {
+    fun formatFileSize(sizeBytes: Long): String
+}
+
 fun String.strip00() = this.let {
     var formatted = it
     while (formatted.startsWith("00:")) {
diff --git a/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/di/DomainModule.kt b/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/di/DomainModule.kt
index 7638f64ce..84e3adcc7 100644
--- a/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/di/DomainModule.kt
+++ b/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/di/DomainModule.kt
@@ -2,6 +2,7 @@ package uk.co.sentinelweb.cuer.di
 
 import org.koin.dsl.module
 import uk.co.sentinelweb.cuer.core.mappers.DateTimeFormatter
+import uk.co.sentinelweb.cuer.core.mappers.FileSizeMapper
 import uk.co.sentinelweb.cuer.core.mappers.TimeFormatter
 import uk.co.sentinelweb.cuer.core.mappers.TimeSinceFormatter
 import uk.co.sentinelweb.cuer.core.providers.CoroutineContextProvider
@@ -18,6 +19,7 @@ object DomainModule {
         factory<TimeProvider> { TimeProviderImpl() }
         factory { TimeSinceFormatter(get(), get()) }
         factory { TimeFormatter() }
+        factory<FileSizeMapper> { FileSizeMapper() }
         factory { DateTimeFormatter() }
     }
 
@@ -29,4 +31,4 @@ object DomainModule {
     }
 
     val allModules = listOf(coreModule, domainModule)
-}
\ No newline at end of file
+}
diff --git a/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/domain/MediaDomain.kt b/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/domain/MediaDomain.kt
index 0c5d7dbcf..75f9a97ed 100644
--- a/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/domain/MediaDomain.kt
+++ b/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/domain/MediaDomain.kt
@@ -28,6 +28,7 @@ data class MediaDomain(
     val isLiveBroadcastUpcoming: Boolean = false,
     val playFromStart: Boolean = false,
     @Contextual val broadcastDate: LocalDateTime? = null, // todo https://github.com/sentinelweb/cuer/issues/196
+    val length: Long? = null,
 ) : Domain {
 
     enum class MediaTypeDomain {
diff --git a/domain/src/iosMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt b/domain/src/iosMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
new file mode 100644
index 000000000..579ffeaaa
--- /dev/null
+++ b/domain/src/iosMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
@@ -0,0 +1,7 @@
+package uk.co.sentinelweb.cuer.core.mappers
+
+actual class FileSizeMapper {
+    actual fun formatFileSize(sizeBytes: Long): String {
+        TODO("Not yet implemented")
+    }
+}
diff --git a/domain/src/jsMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt b/domain/src/jsMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
new file mode 100644
index 000000000..579ffeaaa
--- /dev/null
+++ b/domain/src/jsMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
@@ -0,0 +1,7 @@
+package uk.co.sentinelweb.cuer.core.mappers
+
+actual class FileSizeMapper {
+    actual fun formatFileSize(sizeBytes: Long): String {
+        TODO("Not yet implemented")
+    }
+}
diff --git a/domain/src/jvmMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt b/domain/src/jvmMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
new file mode 100644
index 000000000..bc1b0d49e
--- /dev/null
+++ b/domain/src/jvmMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/FileSizeMapper.kt
@@ -0,0 +1,28 @@
+package uk.co.sentinelweb.cuer.core.mappers
+
+@Suppress("EXPECT_ACTUAL_CLASSIFIERS_ARE_IN_BETA_WARNING")
+actual class FileSizeMapper {
+    actual fun formatFileSize(sizeBytes: Long): String =
+        formatFileSize(bytes = sizeBytes)
+}
+
+/**
+ * Formats file size in bytes to a human-readable string with appropriate unit (G, M, K).
+ * @param bytes The file size in bytes
+ * @param decimalPlaces Number of decimal places to include (default: 1)
+ * @return Formatted string representation of the file size
+ */
+fun formatFileSize(bytes: Long, decimalPlaces: Int = 1): String {
+    if (bytes <= 0) return "0"
+
+    val units = arrayOf("", "K", "M", "G", "T")
+    val digitGroups = (Math.log10(bytes.toDouble()) / Math.log10(1024.0)).toInt()
+
+    val format = if (decimalPlaces > 0) "%.${decimalPlaces}f %s" else "%.0f %s"
+
+    return String.format(
+        format,
+        bytes / Math.pow(1024.0, digitGroups.toDouble()),
+        units[digitGroups.coerceAtMost(units.size - 1)]
+    ).trim()
+}
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
index 0a10bd3cc..13ce4547c 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
@@ -2,6 +2,7 @@ package uk.co.sentinelweb.cuer.app.ui.filebrowser
 
 import androidx.compose.foundation.*
 import androidx.compose.foundation.layout.*
+import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.material3.*
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
@@ -145,6 +146,7 @@ object FilesComposeables {
     @Composable
     private fun FilesView(model: FilesContract.Model, viewModel: FilesContract.ViewModel) {
         Box(contentAlignment = Alignment.Center, modifier = Modifier.fillMaxSize()) {
+            // todo lazy column
             Column(
                 modifier = Modifier.padding(8.dp)
                     .background(MaterialTheme.colorScheme.surface)
@@ -214,26 +216,84 @@ object FilesComposeables {
                     modifier = Modifier.padding(4.dp)
                 )
 
-                if (listItem.timeSince != null) {
-                    Row(Modifier.fillMaxWidth()) {
-                        val text = "${listItem.episodeNumber ?: ""} ${listItem.ext ?: ""}".trim()
-                        if (text.isNotBlank()) {
-                            Text(
-                                text = text,
-                                style = MaterialTheme.typography.bodyMedium,
-                                color = MaterialTheme.colorScheme.onSurface,
-                                modifier = Modifier.padding(4.dp).align(CenterVertically)
-                            )
-                        }
+                Row(
+                    Modifier.fillMaxWidth()
+                        .horizontalScroll(rememberScrollState())
+                ) {
+                    listItem.episodeNumber?.apply {
                         Text(
-                            text = listItem.timeSince,
+                            text = this,
+                            style = MaterialTheme.typography.bodyMedium,
+                            color = Color.White,
+                            fontWeight = FontWeight.Bold,
+                            modifier = Modifier
+                                .padding(4.dp)
+                                .background(
+                                    color = Color.Red.darken(0.5f).copy(alpha = 0.5f),
+                                    shape = RoundedCornerShape(4.dp)
+                                )
+                                .padding(4.dp)
+                                .align(CenterVertically)
+                        )
+                    }
+
+                    listItem.ext?.apply {
+                        Text(
+                            text = this,
+                            style = MaterialTheme.typography.bodyMedium,
+                            color = Color.White,
+                            fontWeight = FontWeight.Bold,
+                            modifier = Modifier
+                                .padding(4.dp)
+                                .background(
+                                    color = Color.Magenta.darken(0.5f).copy(alpha = 0.5f),
+                                    shape = RoundedCornerShape(4.dp)
+                                )
+                                .padding(4.dp)
+                                .align(CenterVertically)
+                        )
+                    }
+                    listItem.sizeText?.apply {
+                        Text(
+                            text = this,
+                            style = MaterialTheme.typography.bodyMedium,
+                            color = Color.White,
+                            fontWeight = FontWeight.Bold,
+                            modifier = Modifier
+                                .padding(4.dp)
+                                .background(
+                                    color = Color.Green.darken(0.5f).copy(alpha = 0.5f),
+                                    shape = RoundedCornerShape(4.dp)
+                                )
+                                .padding(2.dp)
+                                .align(CenterVertically)
+                        )
+                    }
+                    listItem.timeSince?.apply {
+                        Text(
+                            text = this,
                             style = MaterialTheme.typography.bodySmall,
-                            color = Color.Gray,
-                            modifier = Modifier.padding(2.dp).align(CenterVertically)
+                            color = Color.White,
+                            fontWeight = FontWeight.Bold,
+                            modifier = Modifier
+                                .padding(4.dp)
+                                .background(
+                                    color = Color.Blue.darken(0.5f).copy(alpha = 0.5f),
+                                    shape = RoundedCornerShape(4.dp)
+                                ).padding(2.dp)
+                                .align(CenterVertically)
                         )
                     }
                 }
             }
         }
     }
+
+    private fun Color.darken(factor: Float) = let {
+        it.copy(
+            red = it.red * factor,
+            green = it.green * factor,
+            blue = it.blue * factor
+        )
+    }
 }
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
index 6c11b114c..c3d427f21 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
@@ -51,6 +51,8 @@ interface FilesContract {
         val ext: String? = null,
         val episodeNumber: String? = null,
         val timeSince: String? = null,
+        val size: Long?,
+        val sizeText: String?,
     ) {
         @Serializable
         enum class ListItemType {
@@ -84,7 +86,7 @@ interface FilesContract {
 
     companion object {
         val module = module {
-            factory { FilesModelMapper(get()) }
+            factory { FilesModelMapper(get(), get()) }
         }
     }
 }
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt
index a713c3028..ebbe71b3f 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesModelMapper.kt
@@ -4,6 +4,7 @@ import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.ListItem
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.ListItem.ListItemType.*
 import uk.co.sentinelweb.cuer.app.ui.filebrowser.FilesContract.Sort.*
 import uk.co.sentinelweb.cuer.app.usecase.GetFolderListUseCase.Companion.PARENT_FOLDER_TEXT
+import uk.co.sentinelweb.cuer.core.mappers.FileSizeMapper
 import uk.co.sentinelweb.cuer.core.mappers.TimeSinceFormatter
 import uk.co.sentinelweb.cuer.domain.Domain
 import uk.co.sentinelweb.cuer.domain.MediaDomain.MediaTypeDomain
@@ -13,7 +14,8 @@ import uk.co.sentinelweb.cuer.domain.PlaylistItemDomain
 import uk.co.sentinelweb.cuer.domain.ext.name
 
 class FilesModelMapper(
-    private val timeSinceFormatter: TimeSinceFormatter
+    private val timeSinceFormatter: TimeSinceFormatter,
+    private val fileSizeMapper: FileSizeMapper,
 ) {
 
     fun map(
@@ -69,6 +71,8 @@ class FilesModelMapper(
     ) = cleanTitle(it).copy(
         dateModified = domain.dateAdded,
         isDirectory = true,
+        size = domain.media.length,
+        sizeText = fileSizeMapper.formatFileSize(domain.media.length ?: 0),
         type = when (domain.media.mediaType) {
             MediaTypeDomain.VIDEO -> VIDEO
             MediaTypeDomain.AUDIO -> AUDIO
@@ -91,6 +95,8 @@ class FilesModelMapper(
         tags = listOf(),
         isDirectory = true,
         type = UP,
+        size = null,
+        sizeText = null,
     ) to domain
 
     val unwantedSubstrings =
@@ -140,6 +146,8 @@ class FilesModelMapper(
             type = FILE,
             ext = ext,
             episodeNumber = season,
+            size = null,
+            sizeText = null
         )
     }
 }
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
index b28034d8d..ec0112593 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
@@ -258,7 +258,9 @@ class FilesViewModel(
                 ?.takeIf { it.children.isNotEmpty() || it.playlist.items.isNotEmpty() }
                 ?.also { folderOk ->
                     val upItem = folderOk.children.find { PARENT_FOLDER_TEXT.equals(it.title) }
-                        .also { log.d("update: ${folderOk.children.size} items") }
+                    log.d("update: ${folderOk.children.size} items")
+                    log.d("updateJson: ")
+                    log.d(folderOk.toString())
                     _stateObservable.updateAndGet {
                         val newFolder = folderOk.copy(
                             children = upItem?.let { folderOk.children.minus(it) } ?: folderOk.children
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/usecase/GetFolderListUseCase.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/usecase/GetFolderListUseCase.kt
index 5bf7ffb30..39175653d 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/usecase/GetFolderListUseCase.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/usecase/GetFolderListUseCase.kt
@@ -136,6 +136,7 @@ class GetFolderListUseCase(
                 platform = FILESYSTEM,
                 platformId = truncatedPath,
                 url = "file://${truncatedPath}",
+                length = fileProperties.size,
                 channelData = ChannelDomain(
                     id = guidCreator.create().toIdentifier(MEMORY),
                     platform = FILESYSTEM,

From 5e2bd0f497831bab93b0853e331499d9e7a739c9 Mon Sep 17 00:00:00 2001
From: sentinelweb <robmunro@robs-MacBook-Pro.local>
Date: Sat, 28 Jun 2025 14:09:57 +0200
Subject: [PATCH 4/7] #496 - mth -> mo

---
 .../co/sentinelweb/cuer/core/mappers/TimeSinceFormatter.kt  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/TimeSinceFormatter.kt b/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/TimeSinceFormatter.kt
index f58c0ab89..4d6cad95a 100644
--- a/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/TimeSinceFormatter.kt
+++ b/domain/src/commonMain/kotlin/uk/co/sentinelweb/cuer/core/mappers/TimeSinceFormatter.kt
@@ -21,7 +21,7 @@ class TimeSinceFormatter(
                 differenceSeconds < SEC_TO_HOURS -> "${differenceSeconds / SEC_TO_MIN}m"
                 differenceSeconds < SEC_TO_DAYS -> "${differenceSeconds / SEC_TO_HOURS}h"
                 differenceSeconds < SEC_TO_MONTHS -> "${differenceSeconds / SEC_TO_DAYS}d"
-                differenceSeconds < SEC_TO_YEARS -> "${differenceSeconds / SEC_TO_MONTHS}mth"
+                differenceSeconds < SEC_TO_YEARS -> "${differenceSeconds / SEC_TO_MONTHS}mo"
                 differenceSeconds < SEC_TO_YEARS * 20 -> "${differenceSeconds / SEC_TO_YEARS}y"
                 else -> "--"
             }
@@ -37,7 +37,7 @@ class TimeSinceFormatter(
             positiveSeconds < SEC_TO_HOURS -> "$sign${positiveSeconds / SEC_TO_MIN}m"
             positiveSeconds < SEC_TO_DAYS -> "$sign${positiveSeconds / SEC_TO_HOURS}h"
             positiveSeconds < SEC_TO_MONTHS -> "$sign${positiveSeconds / SEC_TO_DAYS}d"
-            positiveSeconds < SEC_TO_YEARS -> "$sign${positiveSeconds / SEC_TO_MONTHS}mth"
+            positiveSeconds < SEC_TO_YEARS -> "$sign${positiveSeconds / SEC_TO_MONTHS}mo"
             positiveSeconds < SEC_TO_YEARS * 20 -> "$sign${positiveSeconds / SEC_TO_YEARS}y"
             else -> "--"
         }
@@ -50,4 +50,4 @@ class TimeSinceFormatter(
         private val SEC_TO_MONTHS = 60 * 60 * 24 * 30
         private val SEC_TO_YEARS = 60 * 60 * 24 * 365
     }
-}
\ No newline at end of file
+}

From 9f52df2fe8c788ac58780b9292fc44870b76812f Mon Sep 17 00:00:00 2001
From: sentinelweb <robmunro@robs-MacBook-Pro.local>
Date: Sat, 28 Jun 2025 14:25:50 +0200
Subject: [PATCH 5/7] #496 - cleanup

---
 .../work/worker/UpcomingVideosCheckWorker.kt  |  3 +--
 .../app/ui/filebrowser/FilesComposeables.kt   |  8 ++++----
 .../cuer/app/ui/filebrowser/FilesContract.kt  | 19 +++++++++----------
 .../cuer/app/ui/filebrowser/FilesViewModel.kt |  1 -
 4 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/app/src/main/java/uk/co/sentinelweb/cuer/app/work/worker/UpcomingVideosCheckWorker.kt b/app/src/main/java/uk/co/sentinelweb/cuer/app/work/worker/UpcomingVideosCheckWorker.kt
index db3a7c63c..f148b8465 100644
--- a/app/src/main/java/uk/co/sentinelweb/cuer/app/work/worker/UpcomingVideosCheckWorker.kt
+++ b/app/src/main/java/uk/co/sentinelweb/cuer/app/work/worker/UpcomingVideosCheckWorker.kt
@@ -29,9 +29,8 @@ class UpcomingVideosCheckWorker(
             Result.failure()
         }
 
-
     companion object {
         val WORK_NAME = "UpcomingVideosCheck"
         val MINS_CHECK = 30
     }
-}
\ No newline at end of file
+}
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
index 13ce4547c..5640032e0 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesComposeables.kt
@@ -229,7 +229,7 @@ object FilesComposeables {
                             modifier = Modifier
                                 .padding(4.dp)
                                 .background(
-                                    color = Color.Red.darken(0.5f).copy(alpha = 0.5f),
+                                    color = Color.Red.darken(0.8f).copy(alpha = 0.5f),
                                     shape = RoundedCornerShape(4.dp)
                                 )
                                 .padding(4.dp)
@@ -246,7 +246,7 @@ object FilesComposeables {
                             modifier = Modifier
                                 .padding(4.dp)
                                 .background(
-                                    color = Color.Magenta.darken(0.5f).copy(alpha = 0.5f),
+                                    color = Color.Black.darken(0.9f).copy(alpha = 0.5f),
                                     shape = RoundedCornerShape(4.dp)
                                 )
                                 .padding(4.dp)
@@ -265,7 +265,7 @@ object FilesComposeables {
                                     color = Color.Green.darken(0.5f).copy(alpha = 0.5f),
                                     shape = RoundedCornerShape(4.dp)
                                 )
-                                .padding(2.dp)
+                                .padding(4.dp)
                                 .align(CenterVertically)
                         )
                     }
@@ -280,7 +280,7 @@ object FilesComposeables {
                                 .background(
                                     color = Color.Blue.darken(0.5f).copy(alpha = 0.5f),
                                     shape = RoundedCornerShape(4.dp)
-                                ).padding(2.dp)
+                                ).padding(4.dp)
                                 .align(CenterVertically)
                         )
                     }
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
index c3d427f21..df3e88729 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesContract.kt
@@ -27,16 +27,15 @@ interface FilesContract {
 
     @Serializable
     data class State(
-        var sourceRemoteId: GUID? = null,
-        var sourceNode: NodeDomain? = null,
-        var path: String? = null,
-        var currentFolder: PlaylistAndChildrenDomain? = null,
-        var currentListItems: Map<ListItem, Domain>? = null,
-        var upListItem: Pair<ListItem, PlaylistDomain>? = null,
-        var selectedFile: PlaylistItemDomain? = null,
-        var sort: Sort = Sort.Alpha,
-        var sortAcending: Boolean = false,
-        var loading: Boolean = true,
+        val sourceNode: NodeDomain? = null,
+        val path: String? = null,
+        val currentFolder: PlaylistAndChildrenDomain? = null,
+        val currentListItems: Map<ListItem, Domain>? = null,
+        val upListItem: Pair<ListItem, PlaylistDomain>? = null,
+        val selectedFile: PlaylistItemDomain? = null,
+        val sort: Sort = Sort.Alpha,
+        val sortAcending: Boolean = false,
+        val loading: Boolean = true,
     )
 
     enum class Sort { Alpha, Time, Episode }
diff --git a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
index ec0112593..fe742bad6 100644
--- a/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
+++ b/shared/src/commonMain/kotlin/uk/co/sentinelweb/cuer/app/ui/filebrowser/FilesViewModel.kt
@@ -73,7 +73,6 @@ class FilesViewModel(
                 currentFolder = null,
                 currentListItems = null,
                 selectedFile = null,
-                sourceRemoteId = null,
             )
         })
     }

From 01c142abf0ab6fefcb8fb81aa237b48adf7eebe7 Mon Sep 17 00:00:00 2001
From: sentinelweb <robmunro@robs-MacBook-Pro.local>
Date: Sat, 28 Jun 2025 17:48:54 +0200
Subject: [PATCH 6/7] #496 - save length to db

---
 database/build.gradle.kts                      |   3 ---
 .../SqldelightMediaDatabaseRepositoryTest.kt   |   5 ++++-
 .../cuer/db/factory/DatabaseFactory.kt         |   8 +-------
 .../sentinelweb/cuer/db/mapper/MediaMapper.kt  |   8 +++++---
 .../cuer/database/entity/MediaEntity.sq        |   5 +++--
 .../sentinelweb/cuer/database/migrations/2.sqm |   1 +
 .../co/sentinelweb/cuer/database/verify/2.db   | Bin 135168 -> 0 bytes
 .../core/mappers/TimeSinceFormatterTest.kt     |   6 +++---
 8 files changed, 17 insertions(+), 19 deletions(-)
 create mode 100644 database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/migrations/2.sqm
 delete mode 100644 database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/verify/2.db

diff --git a/database/build.gradle.kts b/database/build.gradle.kts
index 31f115cd3..649ad3c50 100644
--- a/database/build.gradle.kts
+++ b/database/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
     kotlin("multiplatform")
     kotlin("native.cocoapods")
     id("com.android.library")
-//    kotlin("com.android.application")
     id("com.squareup.sqldelight")
     kotlin("plugin.serialization")
 }
@@ -10,7 +9,6 @@ plugins {
 group = "uk.co.sentinelweb.cuer"
 version = "1.0"
 
-//val ver_jvm: String by project
 val ver_coroutines: String by project
 val ver_kotlinx_serialization_core: String by project
 val ver_sqldelight: String by project
@@ -19,7 +17,6 @@ val ver_koin: String by project
 val ver_turbine: String by project
 val ver_kotlin_fixture: String by project
 val ver_mockk: String by project
-
 val ver_swift_tools: String by project
 val ver_ios_deploy_target: String by project
 
diff --git a/database/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/db/repository/SqldelightMediaDatabaseRepositoryTest.kt b/database/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/db/repository/SqldelightMediaDatabaseRepositoryTest.kt
index 8461da475..786ae26a1 100644
--- a/database/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/db/repository/SqldelightMediaDatabaseRepositoryTest.kt
+++ b/database/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/db/repository/SqldelightMediaDatabaseRepositoryTest.kt
@@ -14,8 +14,8 @@ import org.koin.test.inject
 import uk.co.sentinelweb.cuer.app.db.Database
 import uk.co.sentinelweb.cuer.app.db.repository.ChannelDatabaseRepository
 import uk.co.sentinelweb.cuer.app.db.repository.ConflictException
-import uk.co.sentinelweb.cuer.app.db.repository.MediaDatabaseRepository
 import uk.co.sentinelweb.cuer.app.db.repository.DbResult
+import uk.co.sentinelweb.cuer.app.db.repository.MediaDatabaseRepository
 import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Filter.*
 import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Operation.DELETE
 import uk.co.sentinelweb.cuer.app.orchestrator.OrchestratorContract.Operation.FULL
@@ -148,6 +148,7 @@ class SqldelightMediaDatabaseRepositoryTest : KoinTest {
                 channelData = initialSaved.channelData,
                 thumbNail = initialSaved.thumbNail,
                 image = initialSaved.image,
+                length = initialSaved.length,
                 broadcastDate = null,
             )
             val updated = sut.save(changed, emit = true, flat = false).data!!
@@ -178,6 +179,7 @@ class SqldelightMediaDatabaseRepositoryTest : KoinTest {
                     ),
                     thumbNail = media.thumbNail?.copy(id = saved[i].thumbNail?.id),
                     image = media.image?.copy(id = saved[i].image?.id),
+                    length = media.length,
                 )
             }
 
@@ -207,6 +209,7 @@ class SqldelightMediaDatabaseRepositoryTest : KoinTest {
                     thumbNail = it.thumbNail,
                     image = it.image,
                     broadcastDate = null,
+                    length = it.length,
                 )
             }
             val updated = sut.save(changed, emit = true, flat = false).data!!
diff --git a/database/src/commonMain/kotlin/uk/co/sentinelweb/cuer/db/factory/DatabaseFactory.kt b/database/src/commonMain/kotlin/uk/co/sentinelweb/cuer/db/factory/DatabaseFactory.kt
index 1703bf8be..9156a0817 100644
--- a/database/src/commonMain/kotlin/uk/co/sentinelweb/cuer/db/factory/DatabaseFactory.kt
+++ b/database/src/commonMain/kotlin/uk/co/sentinelweb/cuer/db/factory/DatabaseFactory.kt
@@ -47,16 +47,10 @@ class DatabaseFactory(
             )
         ).apply {
             log.d("Database.Schema.version ${Database.Schema.version} prefs.dbVersion ${prefs.dbVersion}")
-//        }.apply {
-//            Database.Schema.migrate(
-//                driver = driver,
-//                oldVersion = prefs.dbVersion,
-//                newVersion = Database.Schema.version,
-//            )
         }.also {
             prefs.dbVersion = Database.Schema.version
         }.apply {
             log.d("Database.Schema.version ${Database.Schema.version} prefs.dbVersion ${prefs.dbVersion}")
         }
     }
-}
\ No newline at end of file
+}
diff --git a/database/src/commonMain/kotlin/uk/co/sentinelweb/cuer/db/mapper/MediaMapper.kt b/database/src/commonMain/kotlin/uk/co/sentinelweb/cuer/db/mapper/MediaMapper.kt
index 70557a4d2..6aa8f7a2e 100644
--- a/database/src/commonMain/kotlin/uk/co/sentinelweb/cuer/db/mapper/MediaMapper.kt
+++ b/database/src/commonMain/kotlin/uk/co/sentinelweb/cuer/db/mapper/MediaMapper.kt
@@ -39,7 +39,8 @@ class MediaMapper(
             isLiveBroadcast = entity.flags.hasFlag(FLAG_LIVE),
             isLiveBroadcastUpcoming = entity.flags.hasFlag(FLAG_LIVE_UPCOMING),
             playFromStart = entity.flags.hasFlag(FLAG_PLAY_FROM_START),
-            broadcastDate = entity.broadcast_date
+            broadcastDate = entity.broadcast_date,
+            length = entity.length
         )
 
     fun map(domain: MediaDomain): Media = Media(
@@ -58,7 +59,8 @@ class MediaMapper(
         thumb_id = domain.thumbNail?.id?.id?.value,
         image_id = domain.image?.id?.id?.value,
         flags = mapFlags(domain),
-        broadcast_date = domain.broadcastDate
+        broadcast_date = domain.broadcastDate,
+        length = domain.length
     )
 
     private fun mapFlags(domain: MediaDomain):Long =
@@ -69,4 +71,4 @@ class MediaMapper(
             FLAG_LIVE_UPCOMING to domain.isLiveBroadcastUpcoming,
             FLAG_PLAY_FROM_START to domain.playFromStart
         )
-}
\ No newline at end of file
+}
diff --git a/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/entity/MediaEntity.sq b/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/entity/MediaEntity.sq
index 0989e359b..984552127 100644
--- a/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/entity/MediaEntity.sq
+++ b/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/entity/MediaEntity.sq
@@ -17,6 +17,7 @@ CREATE TABLE media (
     thumb_id TEXT,
     image_id TEXT,
     broadcast_date TEXT AS kotlinx.datetime.LocalDateTime DEFAULT NULL,
+    length INTEGER,
     FOREIGN KEY (channel_id) REFERENCES channel(id)
 );
 
@@ -34,7 +35,7 @@ CREATE INDEX media_description_index ON media(description);
 
 create:
 INSERT INTO media ( id, flags, type, url, title, duration, position, date_last_played, description, platform, platform_id,
-published, channel_id, thumb_id, image_id, broadcast_date ) VALUES ?
+published, channel_id, thumb_id, image_id, broadcast_date, length ) VALUES ?
 --ON CONFLICT (platform, platform_id) DO NOTHING
 ;
 
@@ -43,7 +44,7 @@ published, channel_id, thumb_id, image_id, broadcast_date ) VALUES ?
 
 update:
 REPLACE INTO media ( id, flags, type, url, title, duration, position, date_last_played, description, platform, platform_id,
-published, channel_id, thumb_id, image_id, broadcast_date ) VALUES ?
+published, channel_id, thumb_id, image_id, broadcast_date, length ) VALUES ?
 --   ON CONFLICT (platform, platform_id) DO NOTHING
 ;
 
diff --git a/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/migrations/2.sqm b/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/migrations/2.sqm
new file mode 100644
index 000000000..fbf077eff
--- /dev/null
+++ b/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/migrations/2.sqm
@@ -0,0 +1 @@
+ALTER TABLE media ADD COLUMN length INTEGER DEFAULT NULL;
diff --git a/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/verify/2.db b/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/verify/2.db
deleted file mode 100644
index 3d118bc2b66a238f480066f3f4c71dd5a95b9510..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 135168
zcmeI&O>Y~=83%B#CGCooWXUh`$Wc_URiNSmb{)m=!7u`cmR5!!inb{Uu+gL}#igW8
z`683cB#z;rjG??73iKnixAYL8{RsUAZP7zf6ljW`ie7pwnjShkv%{Ssmy*`VW!t|1
zS>)_9Gtd6!g<S7$J<7XY)!b{g>SfQonVLyyTIy}nOr=tD^!F<L6+iy_QSpZU)uh+M
zUe2Yyzwxs%KY02ZKW1V2o2d)wA7=hC{!#j7dR+hI_=dhQ_Rq0*NB=N-G<tL7_ai?U
znLqQT_BZX_)L(}+8ms)HIfK|sT6flMIMojiYvpG(x9yeaN!LsDs^gYRu2UL3c6p^}
z=eBKgy|8LOHjk@jJ}9Wiv!Yq6J3<VyK|8-X*g+|5Gphf&WBMPcIhcYJVs-CbGDwqV
z@jN1nX3MFz+{S)rAytiVAwga{h4n`}(LASUaxh_0>6$6@u1Ttn^>o%Ccj-B#BhF#3
zR^D$%<a+5CL#fVSGVGvLxoD6(MC)p-OP-cfZC6_Eq31RmyhBzzt8_FZ((i^H%1Vt`
z4=?EC2GLxp56|^#RjKuh5v@xxVY{r*DxKHKZKA!9TC5zD8;xqMH`7@f7b2SN4-DH5
zk5~`S4Wuk-vbN7hv@OMi&2s6@8J%1wT2)Hfdv+)roQr5M3<=xw%dD<GZIDema<`-g
z>9qFzUCv*3{DoNeEaRD=17%*bBVmPsnqj}<5Sz53d8<2f)*xH+TK6tXga+}=M?{BB
zi(CTc>8NZ@QQc1{Xd){*QB!&{rIVWr+EX>5kWzGVRsk2Kr7+O%N)%@q`#Y05xwW8m
z)TX6j7vWRUZA+0#<9v?1ypl1<{Ji$*tXJNxRfDq({!9cdZs+dhZ6RQ0Gba6U9dp}$
zyloa9(BGYW-h5bG-^>-Cm>c$!Yb=6wKzI6W`@UT?!@yO0Ew_{3Hs9c3Y<aP^_<Ly?
zOQn@g+iTWKomNdQY<3!6>zPzSE!Z?+MZGS0!{QiSuTh7+gHC-{9OE_IdU>BN7akro
z(%GdSbO%+rZ0$kOUcX=P&)m$4W-PO4uh~VruwrkStf8#ySiBLXg6Jf=LdLp2p_AOa
zmSW@Iep;g+v88gyYqIyHV5CaR!Hdc6gkcauS80b0C~KYlGp-CK&xnpwKZZPxrk}1L
zH-j}S2HZdPf$Mk&Vu<~MgQ~lK;E9rqWu<lU78#a2KlL}+pNutra_BM(O@H$7m_e47
zw4*!h9K`})-#(N#x^m9Sp;w&7;_S`7S<LseeoQ{x;zL-l49?5o%TwgMbjtpKJ5Dg=
z`YJ0^NhG06C000O?u8<bQb&~g)%;Ck)y~`WTiZ%*YbCd8XRO=0PBxc@4XdclzYQ)c
zZ;hAlkFfdq*#;XsmL2<NR2eH)^evB(znw;{{N4-~gUg3)U}NgE%KkSLF^oLwu-SG8
zOWB~+%JdttfA-355xu|Bu=pDnTc4(R7_ldbeL>m0#NH%rn0yH;QM;{X*{S%s`)9$y
z#BBF>dVb!@#0z^<rcqGr&my`Nj2^eX*?5<h*`Ki^T{FnSg7!s8S>IwJol$0rD1F7r
z(pyjcD>@whUI;()N~hJTHoSHJ!bi-7h>y4H%RIc^boyppucyVW^}_wUy~qOxr)L<r
zvt<{9FlDCjnxaVks0s%~8t=ohpSv1(x@l2qHul{8(tB;X0@P1_F*z2WzX)=SIXU=Q
zD3yA7DicbK^^omMoQP6~&F~==#O#l*kg;x@(aFlfiThk{iyPtB(DRuo|HVwKD{2Ho
z00Izz00bZa0SG_<0uX=z1R#(wfsCIouKyD@YDgCX5P$##AOHafKmY;|fB*y_5KjR2
z|KoWf8Uhf200bZa0SG_<0uX=z1R#(^0o?yj;;12K2tWV=5P$##AOHafKmY;|fIvI}
z-2ac~g=h#s00Izz00bZa0SG_<0uX>e5(RMoKZ&D;oFM=K2tWV=5P$##AOHafKmY>q
z1aSX9o)@Aa009U<00Izz00bZa0SG_<0!b9W{r@D68ghmJ1Rwwb2tWV=5P$##AOHaf
z#1p{ve>^WlLjVF0fB*y_009U<00Izz00fdKfam{{IBLil0uX=z1Rwwb2tWV=5P$##
zAP`Rg_y6O0AsPY@fB*y_009U<00Izz00bbAL;+m?Cvnt}GXx+20SG_<0uX=z1Rwwb
z2tXj70IvVzc_A7C5P$##AOHafKmY;|fB*y_kVFAo|0i+OkTV1z009U<00Izz00bZa
z0SG`Ko&c`@<9Q((0uX=z1Rwwb2tWV=5P$##Ado}>T>mF=)Q~d-AOHafKmY;|fB*y_
z009U<Af5oO|KoWf8Uhf200bZa0SG_<0uX=z1R#(^0bKtlanz7A1Rwwb2tWV=5P$##
zAOHafKp>s~uK(kCAsPY@fB*y_009U<00Izz00bbAL;+m?Cvnt}GXx+20SG_<0uX=z
z1Rwwb2tXj70IvVzc_A7C5P$##AOHafKmY;|fB*y_kVFAo|0i+OkTV1z009U<00Izz
z00bZa0SG`Ko&c`@<9Q((0uX=z1Rwwb2tWV=5P$##Ado}>T>mF=)Q~d-AOHafKmY;|
zfB*y_009U<Af5oO|KoWf8Uhf200bZa0SG_<0uX=z1R#(^fhn4FM*liB^}*EI#OB0e
z`WNZF@js4#HU5eIwf<{;YwTZR)zLqX{&e)t$e%_&ANlT?Uupl)s;R%H-WF%8|D3$L
zq;+@PhEx6UuvUInbK73Y^{Vw!z3RB-lIxVhVy841_u5L)&TZS~PGSAgj%}_NR_(`T
zSmpSZ%m)QEHY<9)CY3wZM{@?TX`Zu#{fBuD9=jamc5G6t+VDiI?g%l+2JQUnU<W7I
z%pKEzNEE0JrXYn_-Fue|(xh2DkI16ga;h!2u^(DURU^iXoIGZyXmT)NQR$i)J&aFh
z4RV*BLptId_G;z*c0{h1jxm(#3?{=4T9u0ixkI$B#=7KbIn{Qh<sN!&v%x!L#j{FB
zLn8fd*rBY{i1qM-PHqs*mHO~puU3^>zZlWF6ce_~3a!$4o!lnc3#rA*LAlYW*8CM2
zmR^Wxwm&dzJ3L}NJU5WCq{&Y4d_>z)OxP@!-kj0Nb)r?n<VxPNL)qY5M1x^S*q&cz
zb@ge3Y|@dtB{fK=wYS%7)%|tHUnm+gK?llS#7DAMq4z@64Eq&_*xn<Wx4JWD4YD<_
zb?>r7Xb|5dMf6}U0rPZJHm9iWCloZ16`iOlJ(<$U%?0hLnovk7IytL=i&AM={H{cC
zma)Gxsgqj^T1RbK8g>yr72UQJsWi^#$n^=G<mR;$YrXxnMn7mu<&M{6?@MBOE(b3r
zUtY-=WPV=zbk-~H)~Z2q@Mj`OU^{m&ZwoLpn=$E+>zLd2<88C>fd1~}^X9|i`ev^9
z#N4o-Tw@U|ANpyvZQr+xW*E3?ujO{~+vXcQjIBo27Jo0Tda1P1X?x9jsne>-h0RXG
zYdw=nC>@(stf<!|Z&)0o%RB0@chITtietQnTQBd^)y2buMmoFn^ZTGGm#sZ0+UxfV
z{+XLu(Trsl?KQh-7gp>olQooe9g8=jR1lp+SIAgaS|@LjVFSu*zsde&tnrgWmsx1K
zJ7E}v(6!%T<IW1%KjX@nvm$@M`_1IxHvO{_BO|`0h<V{3`@nU)12Gf)f`h8Nf8dFd
zjCEVr$>!3qa}?`=e`#7)-Ws2LJZ6xkCGF@AI}zoe@<vxqOgZ$5Q(By&**By4cGxe*
zhhBVsi*p~GqrvyX$T{ki{nhL^!Sw5^tV}DBgfgvI;gES4ia1IgQSMjs_nTEaZ__WM
zE4i(e+^S9I=jd^hj;FEA{*1kRe}qlC&o<atu|oFGs4_OJ=vy8Wf9H)_^}T5;29pod
zz^2q`mHjU>V%T`pVYBTHma;*rmFbs!pHA5+qW3l$7Jt)Xi_SC;BlaV)$txR|*q5Zu
zk}Ym^d)sX_%TC45-9HNsCT6$4%k%SACR*5=GHrrlf7WEI8)tN~vT)-1?k(++BV9Ad
z!h-fiNm<omE}l{5izt1?Dbrg;{p&cK1icV`{*_LvRc(0d{uP~=5fLA7*Oz&Cz3KGL
zy<Sg?TkD1Ud3%uu4o=cAaA(Ud24Tv4;Wb5(I-23oNTYsO_H$PQPd7O#&BmU)UwW@i
z*Ma)kFQ&-i^A|ymF{cPW3#C#oPi0z(u^zICi4#%k@DH(9`}D>AfARkq_zM9DKmY;|
zfB*y_009U<00I#B-xcuh|6errQ`5hjZcophJ(~K@)K^nKnEdzTmy;_Kznz%K9A(n!
zAEhske?C5M{DubN2Lcd)00bZafzt{+{tkWIVm^4>Lfp1s_h0yvI6=|X;Jy!k+AJbY
zez1d8w;nG<v@AVB5j0{(wk*ZTE%PTWe*8Lp)QUc|!XLE~$w+r%l+>?8b}$evcOxCN
zx@YGN@`(2K7JHCmpf@R2>GnH8x61Q6C)bWjLw!KTeoZG=h*n|g@H>h0UMhR>dQ_ji
z5Wi`DM~22*-S1sC@O&h@ktjVV#GZ8MJ*bK2BZoaE>(3=R^TS7Kv*P&*JRez-womp%
z1)h&|%XmIgdUCw?nbCV8Kd>2mNc^8aABp?_r~L|tI0!%h0uX=z1Rwwb2tWV=5P(2(
z1#tbJ+_6LE5P$##AOHafKmY;|fB*y_0D;pA;QIfxQiy{91Rwwb2tWV=5P$##AOHaf
jBv$~}|H&OYWDWrcKmY;|fB*y_009U<00Iy=t-yZ)w}Kx9

diff --git a/domain/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/core/mappers/TimeSinceFormatterTest.kt b/domain/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/core/mappers/TimeSinceFormatterTest.kt
index 7d7a043b5..62af65a14 100644
--- a/domain/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/core/mappers/TimeSinceFormatterTest.kt
+++ b/domain/src/androidUnitTest/kotlin/uk/co/sentinelweb/cuer/core/mappers/TimeSinceFormatterTest.kt
@@ -53,7 +53,7 @@ class TimeSinceFormatterTest {
 
     @Test
     fun formatTimeSince_months() {
-        assertEquals("6mth", sut.formatTimeSince(baseTime - 1000L * 60 * 60 * 24 * 200))
+        assertEquals("6mo", sut.formatTimeSince(baseTime - 1000L * 60 * 60 * 24 * 200))
     }
 
     @Test
@@ -89,7 +89,7 @@ class TimeSinceFormatterTest {
 
     @Test
     fun formatTimeShort_months() {
-        assertEquals("6mth", sut.formatTimeShort(1000L * 60 * 60 * 24 * 200))
+        assertEquals("6mo", sut.formatTimeShort(1000L * 60 * 60 * 24 * 200))
     }
 
     @Test
@@ -102,4 +102,4 @@ class TimeSinceFormatterTest {
         assertEquals("--", sut.formatTimeShort(1000L * 60 * 60 * 24 * 365 * 21))
     }
 
-}
\ No newline at end of file
+}

From 8e82346efd3974fe265173ccd57350b07a49c799 Mon Sep 17 00:00:00 2001
From: sentinelweb <robmunro@robs-MacBook-Pro.local>
Date: Sat, 28 Jun 2025 18:05:41 +0200
Subject: [PATCH 7/7] #496 - fix default vaule

---
 .../sqldelight/uk/co/sentinelweb/cuer/database/migrations/2.sqm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/migrations/2.sqm b/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/migrations/2.sqm
index fbf077eff..b1e34e1a2 100644
--- a/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/migrations/2.sqm
+++ b/database/src/commonMain/sqldelight/uk/co/sentinelweb/cuer/database/migrations/2.sqm
@@ -1 +1 @@
-ALTER TABLE media ADD COLUMN length INTEGER DEFAULT NULL;
+ALTER TABLE media ADD COLUMN length INTEGER;