-
Notifications
You must be signed in to change notification settings - Fork 2
Add Docker build workflow #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Build Fails Due to Missing Dev Dependencies
The Dockerfile installs only production dependencies using pnpm install --frozen-lockfile --prod
, but subsequently attempts to build the project with pnpm build
. This fails because the build step, typical for TypeScript projects, requires development dependencies (e.g., TypeScript compiler, build tools) that are excluded by the production-only install.
Dockerfile#L6-L10
Lines 6 to 10 in 25279e6
COPY package.json pnpm-lock.yaml ./ | |
RUN pnpm install --frozen-lockfile --prod | |
# Copy source | |
COPY . . | |
RUN pnpm build |
BugBot free trial expires on June 13, 2025
You have used $0.00 of your $0.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for building the application with Docker by including new documentation, a Dockerfile, and a GitHub Action workflow for automated Docker builds.
- Added Docker instructions in README.md.
- Added a Dockerfile to containerize the app.
- Created a GitHub Action workflow to build the Docker image on push and pull requests.
- Introduced an MIT LICENSE file.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
README.md | Added Docker build and run instructions to help users containerize the app. |
LICENSE | Introduced the MIT license for the project. |
Dockerfile | Provided a containerization configuration to build the production image. |
.github/workflows/docker-build.yml | Set up a GitHub Action to verify that the Docker image builds correctly. |
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Build Docker image | ||
run: docker build . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the README instructions, consider adding '-t mcp-notion' to the docker build command, e.g., 'docker build -t mcp-notion .'.
run: docker build . | |
run: docker build -t mcp-notion . |
Copilot uses AI. Check for mistakes.
Summary
Testing
npm run lint -- --fix=false
(fails: Delete whitespace)npm run build
https://chatgpt.com/codex/tasks/task_e_6843172e9d6c8327919ab2c509a81d3f