-
Notifications
You must be signed in to change notification settings - Fork 376
added some tests to catalog and shopping cart tests #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lblake
wants to merge
1
commit into
serenity-dojo:java-challenge-start
Choose a base branch
from
lblake:java-challenge-start
base: java-challenge-start
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
src/main/java/com/serenitydojo/fruitmarket/FruitUnavailableException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package com.serenitydojo.fruitmarket; | ||
|
||
public class FruitUnavailableException extends RuntimeException { | ||
public FruitUnavailableException(String message) { | ||
super(message); | ||
} | ||
|
||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
src/test/java/com/serenitydojo/fruitmarket/TheShoppingCart.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
package com.serenitydojo.fruitmarket; | ||
|
||
import org.junit.Before; | ||
import org.junit.Test; | ||
|
||
import static com.serenitydojo.fruitmarket.Fruit.*; | ||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
|
||
public class TheShoppingCart { | ||
|
||
Catalog catalog; | ||
ShoppingCart cart; | ||
|
||
@Before | ||
public void setupCatalog() { | ||
catalog = new Catalog(); | ||
catalog.setPriceOf(Apple).to(4.00) | ||
.setPriceOf(Orange).to(5.50) | ||
.setPriceOf(Banana).to(4.50) | ||
.setPriceOf(Pear).to(4.50); | ||
|
||
cart = new ShoppingCart(catalog); | ||
} | ||
|
||
@Test | ||
public void shouldStartWithNoItems() { | ||
assertThat(cart.getItems()).isEmpty(); | ||
} | ||
|
||
@Test | ||
public void shouldKeepTrackOfItemsAddedToTheCart() { | ||
cart.add(2.0).kilosOf(Apple) | ||
.add(3.0).kilosOf(Orange); | ||
|
||
assertThat(cart.getItems()).hasSize(2); | ||
} | ||
|
||
@Test | ||
public void shouldUseTheCatalogToCalculateThePriceOfItemsAddedToTheCart() { | ||
cart.add(2.0).kilosOf(Apple) | ||
.add(2.0).kilosOf(Orange) | ||
.add(1.0).kilosOf(Pear); | ||
|
||
assertThat(cart.getTotalPrice()).isEqualTo(23.50); | ||
} | ||
|
||
@Test | ||
public void shouldKeepTrackOfTheTotalPrice() { | ||
cart.add(2.0).kilosOf(Apple); | ||
|
||
ShoppingCartItem apples = cart.getItems().get(0); | ||
|
||
assertThat(apples.getFruit()).isEqualTo(Apple); | ||
assertThat(apples.getQuantity()).isEqualTo(2.0); | ||
assertThat(apples.getTotalCost()).isEqualTo(8.00); | ||
} | ||
|
||
@Test | ||
public void shouldGiveBulkDiscountsDiscount() { | ||
cart.add(10.0).kilosOf(Apple); | ||
|
||
assertThat(cart.getTotalPrice()).isEqualTo(36.00); | ||
} | ||
|
||
@Test | ||
public void buildDiscountsOnlyApplyToQuantitiesOverFiveKgs() { | ||
cart.add(10.0).kilosOf(Apple); | ||
cart.add(2.00).kilosOf(Orange); | ||
|
||
assertThat(cart.getTotalPrice()).isEqualTo(47.00); | ||
} | ||
|
||
// Test I added | ||
@Test | ||
public void shouldNotAllowNegativeBalance(){ | ||
cart.add(10.0).kilosOf(Apple); | ||
cart.add(2.00).kilosOf(Orange); | ||
|
||
assertThat(cart.getTotalPrice()).isNotEqualTo(-51.0); | ||
|
||
} | ||
|
||
|
||
|
||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of checking for negative balances but I'm not sure if this test is very useful in it's current form. Maybe have the code throw an exception if you try to add a negative quantity to the cart or a negative price in the catalog, and have tests that check for those?