Session middleware commit data after redirection

[jezikk]

Session middleware doesn't commit data after redirect which is problem if you want store some data before redirection to auth server.

This is my auth.callback router where I want to replace my custom session-middleware by session-middleware from remix-utils.

export async function loader({ request, context }: Route.LoaderArgs) {
  const { session, commitSession } = context.get(sessionContext);
  const { openIdClient } = context.get(adapterContext);

  const params = getSignInVerifyParamsFromSession(session);

  if (!params) {
    throw redirectDocument(href("/"));
  }

  const { route, ...verifyParams } = params;
  const url = new URL(request.url);
  const callbackUri = `${getHostUrl(request)}${url.pathname}${url.search}`;

  const { data: tokens, error } = await until(() =>
    openIdClient.validateAuthorizationCallback(callbackUri, verifyParams),
  );

  if (error) {
    console.error("⛔️ Failed validateAuthorizationCallback", error);
    unsetSignInVerifyParamsFromSession(session);
    return redirectDocument(route, { headers: await commitSession(session) });
  }

  unsetSignInVerifyParamsFromSession(session);
  setTokensToSession(tokens, session);
  context.set(authContext, {
    user: parseUserDataFromAccessToken(tokens.accessToken),
    tokens,
  });

  return redirectDocument(route, { headers: await commitSession(session) });
}

[sergiodxa]

I just added a test to ensure this works (839fc93 and ae1e198), it seems the issue is when throwing a redirect, RR may not be sending the thrown redirect to the middleware.