perf: seperate cppcheck of ci (#213)

msclock · web-flow · commit 3aa2c83517e3 · 2024-04-15T10:14:18.000+08:00
Signed-off-by: msclock &lt;msclock@qq.com&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -114,7 +114,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Prepare for lcov
         if: contains(matrix.compiler, 'gcc')
@@ -195,7 +194,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Install llvm through brew
         if: contains(matrix.compiler, 'llvm')
@@ -415,7 +413,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Configure CMake
         run: >
@@ -465,7 +462,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Install valgrind
         run: sudo apt-get install valgrind
@@ -489,6 +485,51 @@ jobs:
         run: cmake --build --preset=default --target ExperimentalMemCheck
 
 
+  cppcheck:
+    runs-on: macos-12
+    needs: [pre-commit, consistency]
+    timeout-minutes: 15
+
+    steps:
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
+        with:
+          fetch-depth: 0
+
+      - name: Cache
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4
+        with:
+          path: |
+            ~/vcpkg
+            ~/.cache/vcpkg
+          key: x64-osx-gcc-13-${{ hashFiles('vcpkg.json') }}
+          restore-keys: x64-osx-gcc-13-${{ hashFiles('vcpkg.json') }}
+
+      - uses: aminya/setup-cpp@v1
+        with:
+          compiler: gcc-13
+          cmake: true
+          ninja: true
+          ccache: true
+          cppcheck: true # use cppcheck of macos, it's newest version
+
+      - name: Configure CMake
+        run: >
+          cmake -S . --preset=default
+          -DCMAKE_BUILD_TYPE=Debug
+          -DCMAKE_CXX_STANDARD=20
+          -DCMAKE_C_COMPILER="${CC}"
+          -DCMAKE_CXX_COMPILER="${CXX}"
+          -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
+          -DVCPKG_TARGET_TRIPLET=x64-osx
+          -DUSE_CPPCHECK_WARNINGS_AS_ERRORS=ON
+          -DUSE_SANITIZER=OFF
+          -DCODE_COVERAGE=OFF
+          -DBUILD_TESTING=ON
+
+      - name: Build
+        run: cmake --build --preset=default --target all
+
+
   check-docs:
     name: Docs build and checks
     runs-on: ubuntu-22.04
@@ -570,7 +611,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Prepare for lcov
         run: |
@@ -629,7 +669,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Configure CMake
         run: >
@@ -681,7 +720,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Disable preinstalled vcpkg in the runner to test vcpkg automatic installation
         run: echo "VCPKG_INSTALLATION_ROOT=" >> $GITHUB_ENV
@@ -735,7 +773,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Configure CMake
         run: >
@@ -785,7 +822,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Configure CMake
         run: >
@@ -819,6 +855,7 @@ jobs:
       - check-docs
       - check-sanitizers
       - check-valgrind
+      - cppcheck
       - codecov
       - check-export-mode
       - check-auto-vcpkg-install
diff --git a/src/exe/include/distribution.hpp b/src/exe/include/distribution.hpp
@@ -1,7 +1,5 @@
 #pragma once
 
-#include <spdlog/spdlog.h>
-
 namespace exe {
 namespace distribution {
 inline bool is_debug() noexcept {
diff --git a/template/[% if repo_host_type == 'github.com' %].github[% endif %]/workflows/ci.yml.jinja b/template/[% if repo_host_type == 'github.com' %].github[% endif %]/workflows/ci.yml.jinja
@@ -118,7 +118,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Prepare for lcov
         if: contains(matrix.compiler, 'gcc')
@@ -203,7 +202,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Install llvm through brew
         if: contains(matrix.compiler, 'llvm')
@@ -435,7 +433,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Configure CMake
         run: >
@@ -489,7 +486,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Install valgrind
         run: sudo apt-get install valgrind
@@ -513,6 +509,55 @@ jobs:
         run: cmake --build --preset=default --target ExperimentalMemCheck
 
 
+  cppcheck:
+    runs-on: macos-12
+    needs: [pre-commit
+[%- if repo_name == 'ss-cpp' -%]
+    , consistency
+[%- endif -%]
+    ]
+    timeout-minutes: 15
+
+    steps:
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
+        with:
+          fetch-depth: 0
+
+      - name: Cache
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4
+        with:
+          path: |
+            ~/vcpkg
+            ~/.cache/vcpkg
+          key: x64-osx-gcc-13-{{ '${{ hashFiles(\'vcpkg.json\') }}' }}
+          restore-keys: x64-osx-gcc-13-{{ '${{ hashFiles(\'vcpkg.json\') }}' }}
+
+      - uses: aminya/setup-cpp@v1
+        with:
+          compiler: gcc-13
+          cmake: true
+          ninja: true
+          ccache: true
+          cppcheck: true # use cppcheck of macos, it's newest version
+
+      - name: Configure CMake
+        run: >
+          cmake -S . --preset=default
+          -DCMAKE_BUILD_TYPE=Debug
+          -DCMAKE_CXX_STANDARD=20
+          -DCMAKE_C_COMPILER="${CC}"
+          -DCMAKE_CXX_COMPILER="${CXX}"
+          -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
+          -DVCPKG_TARGET_TRIPLET=x64-osx
+          -DUSE_CPPCHECK_WARNINGS_AS_ERRORS=ON
+          -DUSE_SANITIZER=OFF
+          -DCODE_COVERAGE=OFF
+          -DBUILD_TESTING=ON
+
+      - name: Build
+        run: cmake --build --preset=default --target all
+
+
   check-docs:
     name: Docs build and checks
     runs-on: ubuntu-22.04
@@ -602,7 +647,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Prepare for lcov
         run: |
@@ -661,7 +705,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Configure CMake
         run: >
@@ -713,7 +756,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Disable preinstalled vcpkg in the runner to test vcpkg automatic installation
         run: echo "VCPKG_INSTALLATION_ROOT=" >> $GITHUB_ENV
@@ -767,7 +809,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Configure CMake
         run: >
@@ -817,7 +858,6 @@ jobs:
           cmake: true
           ninja: true
           ccache: true
-          cppcheck: true
 
       - name: Configure CMake
         run: >
@@ -851,6 +891,7 @@ jobs:
       - check-docs
       - check-sanitizers
       - check-valgrind
+      - cppcheck
 [%- if use_codecov == true %]
       - codecov
 [%- endif %]
diff --git a/template/src/[% if exe_target != '' %]{{ exe_target }}[% endif %]/include/distribution.hpp.jinja b/template/src/[% if exe_target != '' %]{{ exe_target }}[% endif %]/include/distribution.hpp.jinja
@@ -1,7 +1,5 @@
 #pragma once
 
-#include <spdlog/spdlog.h>
-
 namespace {{ exe_target }} {
 namespace distribution {
 inline bool is_debug() noexcept {
diff --git a/template/vcpkg.json.jinja b/template/vcpkg.json.jinja
@@ -39,7 +39,7 @@
 [%- endif %]
     {
       "name": "cmake-modules",
-      "version": "1.4.32"
+      "version": "1.4.35"
     },
     {
       "name": "robotology-cmake-ycm",
@@ -61,7 +61,7 @@
     "registries": [
       {
         "kind": "git",
-        "baseline": "0343f5b696db112fc93e3f2c306d726fd548f4f6",
+        "baseline": "f09077e2e4df1b730cb2c0768298f4eaaf10afa9",
         "repository": "https://github.com/msclock/cmake-registry",
         "packages": [
 [%- if use_conan == true %]
diff --git a/vcpkg.json b/vcpkg.json
@@ -16,7 +16,7 @@
     },
     {
       "name": "cmake-modules",
-      "version": "1.4.32"
+      "version": "1.4.35"
     },
     {
       "name": "robotology-cmake-ycm",
@@ -38,7 +38,7 @@
     "registries": [
       {
         "kind": "git",
-        "baseline": "0343f5b696db112fc93e3f2c306d726fd548f4f6",
+        "baseline": "f09077e2e4df1b730cb2c0768298f4eaaf10afa9",
         "repository": "https://github.com/msclock/cmake-registry",
         "packages": [
           "cmake-modules",

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@`
`39`	`39`	`[%- endif %]`
`40`	`40`	`{`
`41`	`41`	`"name": "cmake-modules",`
`42`		`- "version": "1.4.32"`
	`42`	`+ "version": "1.4.35"`
`43`	`43`	`},`
`44`	`44`	`{`
`45`	`45`	`"name": "robotology-cmake-ycm",`
`@@ -61,7 +61,7 @@`
`61`	`61`	`"registries": [`
`62`	`62`	`{`
`63`	`63`	`"kind": "git",`
`64`		`- "baseline": "0343f5b696db112fc93e3f2c306d726fd548f4f6",`
	`64`	`+ "baseline": "f09077e2e4df1b730cb2c0768298f4eaaf10afa9",`
`65`	`65`	`"repository": "https://github.com/msclock/cmake-registry",`
`66`	`66`	`"packages": [`
`67`	`67`	`[%- if use_conan == true %]`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`},`
`17`	`17`	`{`
`18`	`18`	`"name": "cmake-modules",`
`19`		`- "version": "1.4.32"`
	`19`	`+ "version": "1.4.35"`
`20`	`20`	`},`
`21`	`21`	`{`
`22`	`22`	`"name": "robotology-cmake-ycm",`
`@@ -38,7 +38,7 @@`
`38`	`38`	`"registries": [`
`39`	`39`	`{`
`40`	`40`	`"kind": "git",`
`41`		`- "baseline": "0343f5b696db112fc93e3f2c306d726fd548f4f6",`
	`41`	`+ "baseline": "f09077e2e4df1b730cb2c0768298f4eaaf10afa9",`
`42`	`42`	`"repository": "https://github.com/msclock/cmake-registry",`
`43`	`43`	`"packages": [`
`44`	`44`	`"cmake-modules",`