Skip to content

Wrong ISO8601 durations #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cdavernas opened this issue Apr 1, 2021 · 1 comment · Fixed by #78
Closed

Wrong ISO8601 durations #75

cdavernas opened this issue Apr 1, 2021 · 1 comment · Fixed by #78
Assignees
@tsurdilo

Comments

@cdavernas
Copy link
Member

cdavernas commented Apr 1, 2021 •
edited
Loading

What happened:

@tsurdilo Following our discussion on the spec repo, it configured my unit tests to run the examples.

My tests fail with the booklending.json file, because an ISO 8601 duration is I believe in an invalid format: PT2W instead of P2W. Am I correct to assume it is a typo?

What you expected to happen:

When ISO 8601 values specify a period of time, they should be prefixed with 'P' instead of 'PT'

How to reproduce it:

Read the 'timeDelay' property with an ISO 8601 duration parser.
@tsurdilo tsurdilo self-assigned this Apr 3, 2021
@tsurdilo
Copy link
Contributor

@neuroglia yeah its a typo, sorry. Will fix asap

@tsurdilo tsurdilo linked a pull request Apr 11, 2021 that will close this issue
Fix ISO 8601 format #78
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsurdilo tsurdilo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ISO 8601 format tsurdilo/sdk-java
2 participants
@tsurdilo @cdavernas