Add data to EventProperties #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
JBBianchi
reviewed
Jan 14, 2025
fjtirado
force-pushed
the
Add_data_to_event_properties
branch
from
eaf7322 to
a96f613
Compare
cdavernas
requested changes
Jan 14, 2025
fjtirado
force-pushed
the
Add_data_to_event_properties
branch
from
3da6cad to
7cbedcd
Compare
ricardozanini
approved these changes
Jan 14, 2025
fjtirado
force-pushed
the
Add_data_to_event_properties
branch
from
7cbedcd to
37f7cf3
Compare
cdavernas
requested changes
Jan 14, 2025
fjtirado
force-pushed
the
Add_data_to_event_properties
branch
from
96e0fc5 to
241c109
Compare
fjtirado
force-pushed
the
Add_data_to_event_properties
branch
5 times, most recently
from
0f8f5bd to
11c1521
Compare
matthias-pichler
suggested changes
Jan 14, 2025
matthias-pichler
approved these changes
Jan 14, 2025
Co-authored-by: Charles d'Avernas <charles.davernas@neuroglia.io> Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
fjtirado
force-pushed
the
Add_data_to_event_properties
branch
from
11c1521 to
91c6cf4
Compare
I was trying different approaches. I think emphasize the possiibilty of using an expression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
Additional information: