From badd2d21dcc12dea8c3dfb00cec3b607ac104973 Mon Sep 17 00:00:00 2001 From: Charles d'Avernas Date: Wed, 28 Aug 2024 13:55:38 +0200 Subject: [PATCH 1/2] - Removed obsolete files - Updated the dsl-reference and schema to add the `await` property to the run task Signed-off-by: Charles d'Avernas --- .markdownlint.yaml | 23 ----------------------- .typo-ci.yml | 34 ---------------------------------- Makefile | 5 ----- dsl-reference.md | 1 + schema/workflow.yaml | 7 +++++++ 5 files changed, 8 insertions(+), 62 deletions(-) delete mode 100644 .markdownlint.yaml delete mode 100644 .typo-ci.yml delete mode 100644 Makefile diff --git a/.markdownlint.yaml b/.markdownlint.yaml deleted file mode 100644 index ee4a52fc..00000000 --- a/.markdownlint.yaml +++ /dev/null @@ -1,23 +0,0 @@ -# Copyright 2020 The Serverless Workflow Specification Authors -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -{ - "default": true, - "MD024": { "allow_different_nesting": true }, - "MD029": { "style": "ordered" }, - "ul-style": false, # MD004 - "line-length": false, # MD013 - "no-inline-html": false, # MD033 - "fenced-code-language": false # MD040 -} diff --git a/.typo-ci.yml b/.typo-ci.yml deleted file mode 100644 index 5eddc282..00000000 --- a/.typo-ci.yml +++ /dev/null @@ -1,34 +0,0 @@ ---- - -# What language dictionaries should it use? Currently Typo CI supports: -# de -# en -# en_GB -# es -# fr -# it -# pt -# pt_BR -dictionaries: - - en - -# Any files/folders we should ignore? -excluded_files: - - ".github/**/*" - - ".vscode/**/*" - - "media/**/*." - - "schema/**/*" - - ".gitignore" - - ".typo-ci.yml" - - ".markdownlint.yaml" - - "Makefile" - -# Any typos we should ignore? -excluded_words: - - typoci - - runtimes - - cncf-wg-serverless - - cncf-serverlessws-maintainers - -# Would you like filenames to also be spellchecked? -spellcheck_filenames: false diff --git a/Makefile b/Makefile deleted file mode 100644 index 0bdfc734..00000000 --- a/Makefile +++ /dev/null @@ -1,5 +0,0 @@ -# will add the license headers to all of our files -# requires go installed in your system: https://golang.org/doc/install -addheaders: - @which addlicense > /dev/null || go get -u github.com/google/addlicense - @addlicense -c "The Serverless Workflow Specification Authors" -l apache . \ No newline at end of file diff --git a/dsl-reference.md b/dsl-reference.md index 68b3346b..a86f674f 100644 --- a/dsl-reference.md +++ b/dsl-reference.md @@ -717,6 +717,7 @@ Provides the capability to execute external [containers](#container-process), [s | run.script | [`script`](#script-process) | `no` | The definition of the script to run.
*Required if `container`, `shell` and `workflow` have not been set.* | | run.shell | [`shell`](#shell-process) | `no` | The definition of the shell command to run.
*Required if `container`, `script` and `workflow` have not been set.* | | run.workflow | [`workflow`](#workflow-process) | `no` | The definition of the workflow to run.
*Required if `container`, `script` and `shell` have not been set.* | +| await | `boolean` | `no` | Determines whether or not the process to run should be awaited for.
*Defaults to `true`.* | ##### Examples diff --git a/schema/workflow.yaml b/schema/workflow.yaml index 1b47ec76..32c61f1f 100644 --- a/schema/workflow.yaml +++ b/schema/workflow.yaml @@ -537,6 +537,13 @@ $defs: type: object title: RunTaskConfiguration description: The configuration of the process to execute. + unevaluatedProperties: false + properties: + await: + type: boolean + default: true + title: AwaitProcessCompletion + description: Whether to await the process completion before continuing. oneOf: - title: RunContainer description: Enables the execution of external processes encapsulated within a containerized environment. From 0e7b3a547cf139817ba15258587b9a5f91ba0312 Mon Sep 17 00:00:00 2001 From: Charles d'Avernas Date: Fri, 30 Aug 2024 16:24:49 +0200 Subject: [PATCH 2/2] Re-added the Makefile, which will be moved/updated in dedicated PR by @ricardozanini Signed-off-by: Charles d'Avernas --- Makefile | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 Makefile diff --git a/Makefile b/Makefile new file mode 100644 index 00000000..0bdfc734 --- /dev/null +++ b/Makefile @@ -0,0 +1,5 @@ +# will add the license headers to all of our files +# requires go installed in your system: https://golang.org/doc/install +addheaders: + @which addlicense > /dev/null || go get -u github.com/google/addlicense + @addlicense -c "The Serverless Workflow Specification Authors" -l apache . \ No newline at end of file