Skip to content

Conversation

joshglasspool
Copy link

Makes it possible to configure the auto-generated self-signed cert via env variables if desired. Maintains the existing defaults for the self-signed cert or ability to provide cert and key file instead. Updated docs to detail the new variables.

@tomschlick
Copy link
Contributor

IMO the php container shouldn't be responsible for creating a self signed cert as that would only be needed on development. You should use another container to do that and then share the certificate via a mount to the php container.

@jaydrogers
Copy link
Member

I agree with @tomschlick. I just put default stuff in there just so something would generate.

Any specific use cases on this @joshglasspool?

@joshglasspool
Copy link
Author

For testing multiple build candidates it’s handy to have a few different self-signed certs. Since the container already makes one, I figured following the convention of making it env configurable was a natural extension. If the consensus is that a sidecar is the right way to go, then it probably makes more sense to just drop cert generation entirely.

@jaydrogers jaydrogers changed the base branch from main to 280-create-a-frankenphp-variation October 7, 2025 16:58
@jaydrogers
Copy link
Member

Thanks for sharing your use case!

I can definitely see this being value in local development environments, especially with SSL_SUBJECT_CN: "*.dev.test,*.gitpod.io,*.ngrok.io,*.nip.io".

If you don't use *.dev.test in local environments and you put this behind Traefik, Traefik won't route the traffic becasue of SNI.

Let me stew on this and see if I get this into 4.0 or 4.1. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants