[breaking][core-graphics] Enforce Sendness of CGEventTap callback (soundness fix) #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @wusyong |
This was referenced Mar 21, 2025
jdm
approved these changes
May 26, 2025
This prevents a failure mode of handling the Result of CGEventTap::new() but not saving the tap itself.
This was previously unsound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an aspect of unsoundness missed in #710. The callback can capture state from the current thread that is not
Send, but the tap can be installed on another thread's event loop.This change fixes the unsoundness while providing a way to safely and conveniently use the API that fits most use cases.
CGEventTap::with(unreleased API) was renamed towith_enabledbecause it actually installs and enables the tap now.Also make CGEventTap
#[must_use]so users ofnewdon't accidentally drop the tap.This change is currently based on #724 but can be rebased if you want to merge it independently.