Skip to content

Deprecate cocoa, cocoa-foundation and io-surface and link to objc2 crates instead#731

Merged
mrobinson merged 3 commits into
servo:mainfrom
madsmtm:deprecate-some
May 16, 2025
Merged

Deprecate cocoa, cocoa-foundation and io-surface and link to objc2 crates instead#731
mrobinson merged 3 commits into
servo:mainfrom
madsmtm:deprecate-some

Conversation

@madsmtm
Copy link
Copy Markdown
Contributor

@madsmtm madsmtm commented May 12, 2025

Resolves part of #729, see that for motivation.

I believe it should be safe to move forwards with deprecating cocoa and cocoa-foundation, their major reverse dependencies have already migrated, so the ecosystem disruption nowadays will be as minimal as possible. For io-surface, the only real dependency seems to be surfman, and I have filed servo/surfman#334 for migrating that.

I'll wait with the other crates for now.

Copy link
Copy Markdown
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a couple small changes. Sorry for the delay here.

Comment thread cocoa/src/lib.rs Outdated
Comment thread io-surface/src/lib.rs Outdated
@madsmtm
Copy link
Copy Markdown
Contributor Author

madsmtm commented May 15, 2025

Sorry for the delay here.

No problem at all, a few days isn't delay ;)

@mrobinson mrobinson added this pull request to the merge queue May 16, 2025
Merged via the queue into servo:main with commit 61b90e7 May 16, 2025
8 checks passed
@madsmtm madsmtm deleted the deprecate-some branch May 16, 2025 17:11
@madsmtm
Copy link
Copy Markdown
Contributor Author

madsmtm commented May 16, 2025

Do you want me to do a version bump PR for it?

@mrobinson
Copy link
Copy Markdown
Member

Do you want me to do a version bump PR for it?

That makes sense to me.

@madsmtm
Copy link
Copy Markdown
Contributor Author

madsmtm commented May 16, 2025

I opened #732 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants