Don't update status on draft PRs.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

Author: jdm

handlers/status_update/__init__.py

@@ -51,6 +51,9 @@ def handle_custom_labels(api, event):
 
 
 def update_rebase_status(api, payload):
+    if "pull_request" not in payload:
+        return
+
     mergeable = payload['pull_request']['mergeable']
 
     # If mergeable is null, the data wasn't available yet.
@@ -64,23 +67,33 @@ def update_rebase_status(api, payload):
         api.add_label(NEED_REBASE)
 
 
+def is_draft_pr(payload):
+    return "pull_request" in payload and payload["pull_request"]["draft"] == True
+
+
 class StatusUpdateHandler(EventHandler):
     def on_pr_opened(self, api, payload):
+        if is_draft_pr(payload):
+            return
+
         labels = api.get_labels()
         if AWAITING_REVIEW not in labels:
             api.add_label(AWAITING_REVIEW)
         update_rebase_status(api, payload)
         handle_custom_labels(api, 'opened')
 
     def on_pr_updated(self, api, payload):
+        if is_draft_pr(payload):
+            return
+
         clear_pr_labels(api)
         api.add_label(AWAITING_REVIEW)
         update_rebase_status(api, payload)
         handle_custom_labels(api, 'updated')
 
     def on_pr_closed(self, api, payload):
         handle_custom_labels(api, 'closed')
-        if "pull_request" in payload and payload['pull_request']['merged']:
+        if "pull_request" in payload and payload['pull_request']['merged'] == True:
             api.remove_label(AWAITING_MERGE)
             handle_custom_labels(api, 'merged')
 

handlers/status_update/tests/new_pr.json

@@ -8,6 +8,7 @@
   "payload": {
     "number": 7076, 
     "pull_request": {
+      "draft": false,
       "mergeable": true,
       "base": {
         "repo": {

handlers/status_update/tests/new_pr_draft.json

@@ -0,0 +1,22 @@
+{
+  "expected": {
+    "labels": [
+    ]
+  }, 
+  "initial": {}, 
+  "payload": {
+    "number": 7076, 
+    "pull_request": {
+      "draft": true,
+      "base": {
+        "repo": {
+          "owner": {
+            "login": "servo"
+          }, 
+          "name": "servo"
+        }
+      }
+    }, 
+    "action": "opened"
+  }
+}

handlers/status_update/tests/new_pr_unmergeable.json

@@ -9,6 +9,7 @@
   "payload": {
     "number": 7076, 
     "pull_request": {
+      "draft": false,
       "mergeable": false,
       "base": {
         "repo": {

handlers/status_update/tests/synchronize.json

@@ -14,6 +14,7 @@
   "payload": {
     "number": 7062, 
     "pull_request": {
+      "draft": false,
       "mergeable": true,
       "base": {
         "repo": {

handlers/status_update/tests/synchronize_changes.json

@@ -6,6 +6,7 @@
   "payload": {
     "number": 7062,
     "pull_request": {
+      "draft": false,
       "mergeable": true,
       "base": {
         "repo": {

handlers/status_update/tests/synchronize_draft.json

@@ -0,0 +1,31 @@
+{
+  "expected": {
+    "labels": [
+      "S-needs-code-changes", 
+      "S-tests-failed", 
+      "S-awaiting-merge"
+    ]
+  }, 
+  "initial": {
+    "labels": [
+      "S-needs-code-changes", 
+      "S-tests-failed", 
+      "S-awaiting-merge"
+    ]
+  }, 
+  "payload": {
+    "number": 7062, 
+    "pull_request": {
+      "draft": true,
+      "base": {
+        "repo": {
+          "owner": {
+            "login": "servo"
+          }, 
+          "name": "servo"
+        }
+      }
+    }, 
+    "action": "synchronize"
+  }
+}

handlers/status_update/tests/synchronize_mergeable.json

@@ -314,6 +314,7 @@
   "payload": {
     "number": 7062, 
     "pull_request": {
+      "draft": false,
       "mergeable": null, 
       "base": {
         "repo": {