Skip to content

Should we check the diffs whenever new code is committed? #127

@ghost

Description

In servo/servo#11267, the author modified the stuff inside python, and I was notified by highfive when the PR was opened. Later, new commits were added, where the author went for modifying the CI scripts (whose watcher is @aneeshusa). Wouldn't it be better if he got notified by it?

I suggest we should check the diff whenever new code is committed. We should probably store the state of the notified watchers somehow and check it before notifying someone again (so that we don't thrash the PR with comments!).

Whenever I think of a new suggestion, I'm worried about #124. Then, there's the problem of feasibility. Can we actually do this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions