Skip to content

Conversation

hundehausen
Copy link
Contributor

@hundehausen hundehausen commented Aug 9, 2025

Dockerfile

  • Removes redundant --verify flag from command
  • Use /bin/ash for adduser: matches Alpine base, bash is not installed per default
  • Replace ADD+chmod with COPY --chmod=0755 for entrypoint.sh
  • Update healthcheck comment to get_height, which now reflects the actual check

README

  • Add link to Monerod reference options for easier discovery of available flags
  • Add security note on Docker publishing to 0.0.0.0 and UFW bypass risk to prevents unintended exposure
  • Always specify --ban-list=/home/monero/ban_list.txt in all examples, because if you add any custom flags, it will override the ones specified in the CMD command in the DOCKERFILE

examples/docker-compose.yml

  • Remove version: '3' header to align with Compose v2+ (schema inferred)
  • Always specify --ban-list=/home/monero/ban_list.txt in all examples, because if you add any custom flags, it will override the ones specified in the CMD command in the DOCKERFILE

Copy link
Owner

@sethforprivacy sethforprivacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely amazing, thank you for your tireless efforts working to improve Monero's ecosystem 🧡

@sethforprivacy sethforprivacy merged commit aebf6ca into sethforprivacy:main Aug 12, 2025
2 checks passed
@hundehausen hundehausen deleted the improvements branch August 12, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants