Skip to content

fix: update UE EngineAssociation 5.6 + safer TCP recv buffer #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

fix: update UE EngineAssociation 5.6 + safer TCP recv buffer #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MCPGameProject/MCPGameProject.uproject
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"FileVersion": 3,
"EngineAssociation": "5.5",
"EngineAssociation": "5.6",
"Category": "",
"Description": "",
"Modules": [
Expand Down
11 changes: 7 additions & 4 deletions MCPGameProject/Plugins/UnrealMCP/Source/UnrealMCP/Private/MCPServerRunnable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
#include "HAL/PlatformTime.h"

// Buffer size for receiving data
const int32 BufferSize = 8192;
namespace
{
constexpr int32 MCPReceiveBufferSize = 8192;
}

FMCPServerRunnable::FMCPServerRunnable(UUnrealMCPBridge* InBridge, TSharedPtr<FSocket> InListenerSocket)
: Bridge(InBridge)
Expand Down Expand Up @@ -56,11 +59,11 @@ uint32 FMCPServerRunnable::Run()
ClientSocket->SetSendBufferSize(SocketBufferSize, SocketBufferSize);
ClientSocket->SetReceiveBufferSize(SocketBufferSize, SocketBufferSize);

uint8 Buffer[8192];
uint8 Buffer[MCPReceiveBufferSize + 1];
while (bRunning)
{
int32 BytesRead = 0;
if (ClientSocket->Recv(Buffer, sizeof(Buffer), BytesRead))
if (ClientSocket->Recv(Buffer, MCPReceiveBufferSize, BytesRead))
{
if (BytesRead == 0)
{
Expand Down Expand Up @@ -180,7 +183,7 @@ void FMCPServerRunnable::HandleClientConnection(TSharedPtr<FSocket> InClientSock

// Properly read full message with timeout
const int32 MaxBufferSize = 4096;
uint8 Buffer[MaxBufferSize];
uint8 Buffer[MaxBufferSize + 1];
FString MessageBuffer;

UE_LOG(LogTemp, Display, TEXT("MCPServerRunnable: Starting message receive loop"));
Expand Down