a14 #49
Open
a14 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pippo8291
commented
Feb 14, 2025
There was a problem hiding this comment.
ok... this may look like A13... maybe could be replace by symlink
There was a problem hiding this comment.
can u test that with a symlink?
er.sh
Outdated
| @@ -479,8 +479,8 @@ F_SIGPATCH(){ | |||
| ERR=$? | |||
| echo "[$FUNCNAME] Signature spoofing patching ended with $ERR" | |||
| echo "[$FUNCNAME] adding signature spoof controller" | |||
| cp $PDIR/*-packages-apps-Settings-src-com-android-settings-development-SpoofSignaturePreferenceController.java ${SRC_TOP}/packages/apps/Settings/src/com/android/settings/development/SpoofSignaturePreferenceController.java || exit 3 | |||
| cp $PDIR/*-packages-apps-Settings-src-com-android-settings-development-SpoofSignatureInfo.java ${SRC_TOP}/packages/apps/Settings/src/com/android/settings/development/SpoofSignatureInfo.java || exit 3 | |||
| [ -f $PDIR/*-packages-apps-Settings-src-com-android-settings-development-SpoofSignaturePreferenceController.java ] && (cp $PDIR/*-packages-apps-Settings-src-com-android-settings-development-SpoofSignaturePreferenceController.java ${SRC_TOP}/packages/apps/Settings/src/com/android/settings/development/SpoofSignaturePreferenceController.java || exit 3) | |||
There was a problem hiding this comment.
could you pls use "if...then..fi" for this and the next check? the reason is that otherwise the script will break when the condition is not true. using the if..then..fi will ensure it only ends with false when there is a (real) problem
Pippo8291
force-pushed
the
a14
branch
2 times, most recently
from
511a138 to
463ca1f
Compare
steadfasterX
reviewed
Apr 8, 2025
There was a problem hiding this comment.
actually I want to to error out if these files cannot be found so I dont want to guard them with such a condition.. if they are not there something is wrong
9 tasks
Pippo8291
force-pushed
the
a14
branch
2 times, most recently
from
ebc0729 to
0bd5a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes should have no effect on older versions.
only the check if files exist before copying it (er.sh) is overlapping, but should be fine...