Skip to content

Guidance for monorepos #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sgb-io opened this issue Jun 29, 2022 · 3 comments
Closed

Guidance for monorepos #108

sgb-io opened this issue Jun 29, 2022 · 3 comments

Comments

@sgb-io
Copy link
Owner

sgb-io commented Jun 29, 2022

  • Should the tool be used at the root or by individual packages? My gut is the root.
  • Are child node_modules ignored by default? I don't think so, but it should be changed to detect yarn workspaces by default
  • Generally, should options that contain paths support wildcard paths? e.g. packages/**/src. My gut feel is that, yes, this should work.
@sgb-io
Copy link
Owner Author

sgb-io commented Jun 29, 2022

There is an issue with monorepos for the current implementation: it is assumed that a single coverage dir exists

@sgb-io
Copy link
Owner Author

sgb-io commented Jun 29, 2022

Update: codehawk-cli works for monorepo projects, but it needs to be installed per-package with a codehawk.json and codehawk src script for each package. This is workable but not ideal. It's probably worth updating the docs to state this whilst support for a single config + script in a monorepo root is worked out.

@sgb-io
Copy link
Owner Author

sgb-io commented May 13, 2023

Closing due to #122

@sgb-io sgb-io closed this as completed May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant