Skip to content

Main dir arg isn't always respected #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sgb-io opened this issue Jun 29, 2022 · 2 comments
Closed

Main dir arg isn't always respected #111

sgb-io opened this issue Jun 29, 2022 · 2 comments

Comments

@sgb-io
Copy link
Owner

sgb-io commented Jun 29, 2022

e.g. codehawk packages/foo - this doesn't work as expected
@sgb-io
Copy link
Owner Author

sgb-io commented Jun 29, 2022

I think this is due to codehawk.ts L34 where cwd() is used in "cli context". It's easily solved by not using cwd for the walkSync call. Q: is there actually a usecase for using cwd? I can't think of one at time of writing.

Note: there is a related problem in that it is assumed there is a single coverage dir and it uses the same wonky cwd logic at the moment.

@sgb-io
Copy link
Owner Author

sgb-io commented May 13, 2023

Closing due to #122

@sgb-io sgb-io closed this as completed May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgb-io