Skip to content

Refactor to improve current scores #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sgb-io opened this issue Jan 8, 2021 · 2 comments
Closed

Refactor to improve current scores #85

sgb-io opened this issue Jan 8, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@sgb-io
Copy link
Owner

sgb-io commented Jan 8, 2021 •
edited
Loading

It would be nice if we could push the worst case to 50+, average to 60-65+.
@sgb-io sgb-io added the enhancement New feature or request label Jan 8, 2021
@sgb-io
Copy link
Owner Author

sgb-io commented Jan 8, 2021

The most major problem in the codebase is the currently handling of paths/dirs/files. There is quite a lot of filesystem logic involved with the tool and the cross-OS (nix + windows) compatibility requirement makes this worse. There is also user input in the form of the options. Often, we have string types like relativeDir or fullPath but this is still difficult to work with.

@sgb-io sgb-io mentioned this issue Jan 9, 2021
Merged
@sgb-io
Copy link
Owner Author

sgb-io commented May 13, 2023

Closing due to #122

@sgb-io sgb-io closed this as completed May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgb-io