Skip to content

Add badgesDirectory option, improved error handling, suppress coverage warnings #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

sgb-io
Copy link
Owner

@sgb-io sgb-io commented Jan 8, 2021

Resolves #70
Resolves #66 to some degree

  • Added the badgesDirectory option to let users configure where the badges go
  • Improved some error handling so that users get specific errors but also generic ones (e.g. "option XYZ not supported" in addition to "could not parse your options file"
  • Turned off coverage warnings whilst it undergoes a rethink (see Re-consider the role of coverage #58)
  • Added an ugly-but-useful verify script. Optional step that helps in local dev - final check before pushing up the work & opening a PR

@sgb-io sgb-io closed this Jan 8, 2021
@sgb-io sgb-io reopened this Jan 8, 2021
@sgb-io sgb-io merged commit 0489d4e into master Jan 8, 2021
@sgb-io sgb-io deleted the feat/better-badge-control branch January 8, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badges path/dir should be configurable Generated badges dir needs manually creating
1 participant