Move dev requirements into pyproject #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromekelleher
approved these changes
Apr 29, 2024
ravwojdyla
force-pushed
the
rav-add-dev-deps
branch
from
f64ba4a to
e694cdf
Compare
|
@jeromekelleher thanks for the review! It looks like I don't have the rights to merge. This PR should be good to go 🙏 EDIT: after this PR, I will rebase #152 and then take a look at the #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #151, which should be reviewed and merged first 1. The only relevant commit here is f64ba4a, which moves the
requirements/development.txtinto the pyproject. Thesedevdependencies can be then installed viapython -m pip install '.[dev]'. See https://packaging.python.org/en/latest/discussions/setup-py-deprecated/#what-commands-should-be-used-instead for doc.Footnotes
I can't change the base of this PR because the Consolidate project config under pyproject #151 is coming from a forked repo ↩