Check dimension sizes for named VCF Number fields #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
force-pushed
the
check-named-dimensions-for-vcf-number
branch
from
fa3199d to
635cac1
Compare
|
I've re-written this so it's now stacked on #361 |
tomwhite
force-pushed
the
check-named-dimensions-for-vcf-number
branch
from
2316e0a to
8f435e1
Compare
tomwhite
force-pushed
the
check-named-dimensions-for-vcf-number
branch
from
8f435e1 to
8158712
Compare
|
I've rebased this on main now that #361 is in |
|
Excellent, looks great. I guess we better get some test coverage on these error cases? (It's very tedious though) |
tomwhite
force-pushed
the
check-named-dimensions-for-vcf-number
branch
from
8158712 to
e042e9f
Compare
|
Added a unit test to ensure coverage. Should be ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #359
This handles Number=R and A, but G is harder. Before I look at that, I wanted to see what you thought about this approach @jeromekelleher?