Skip to content

Null-check after pointer dereference in multiple tiling functions #433

@longxin9715

Description

@longxin9715

Description

Static analysis reports that several OP_TILING_CHECK null-pointer checks are executed after the pointer has already been dereferenced. This makes the check ineffective and may lead to a crash if the pointer is actually nullptr.

Affected Pointers & Locations

csrc\deepep\ops\op_host\moe_distribute_dispatch_v2_tiling.cpp

Pointer Variable Dereference Location Null-Check Location
epWorldSizePtr CheckAndSetGroupInfo L449 Same function, after L449
sharedExpertRankNumPtr CheckAndSetExpertInfo L509 Same function, after L509
moeExpertNumPtr CheckAndSetExpertInfo L507 Same function, after L507
zeroExpertNumPtr CheckAndSetSpecialExpertInfo L572 Same function, after L572
copyExpertNumPtr CheckAndSetSpecialExpertInfo L573 Same function, after L573
constExpertNumPtr CheckAndSetSpecialExpertInfo L574 Same function, after L574

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions