-
Notifications
You must be signed in to change notification settings - Fork 55
feat:adapt x86_64 compilation #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Yael-X, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the build system to enhance its adaptability and support for different architectures, particularly x86_64. It introduces dynamic host architecture detection within CMake, streamlines various build commands for improved robustness, and updates package naming conventions to reflect the system processor. Additionally, the changes simplify the primary build script by removing hardcoded environment variables and adjust include paths to be architecture-agnostic, resulting in a more flexible and maintainable compilation process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adapts the build process for x86_64 architecture. The changes include modifications to CMakeLists.txt, CMakePresets.json, build.sh, and op_host/CMakeLists.txt to handle different architectures and streamline the build process. The cross-compilation logic has been removed, and the package file name now includes the architecture. The review focuses on ensuring the correctness of the architecture-specific configurations and the removal of unnecessary code.
Compilation added on the x86 platform