Skip to content

Conversation

@Yael-X
Copy link
Collaborator

@Yael-X Yael-X commented Oct 23, 2025

Compilation added on the x86 platform

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Yael-X, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the build system to enhance its adaptability and support for different architectures, particularly x86_64. It introduces dynamic host architecture detection within CMake, streamlines various build commands for improved robustness, and updates package naming conventions to reflect the system processor. Additionally, the changes simplify the primary build script by removing hardcoded environment variables and adjust include paths to be architecture-agnostic, resulting in a more flexible and maintainable compilation process.

Highlights

  • Architecture Detection Refactoring: The CMake build system now dynamically determines the host architecture (x86_64 or aarch64) using CMAKE_SYSTEM_PROCESSOR and sets a CANN_HOST_ARCH variable, replacing previous complex cross-compilation logic.
  • Improved CMake Command Usage: Custom commands for directory creation and copying in CMakeLists.txt have been updated to use CMake's built-in -E flag (e.g., CMAKE_COMMAND -E make_directory), enhancing robustness and platform independence.
  • Architecture-Specific Package Naming: CPack package file names now include the CMAKE_SYSTEM_PROCESSOR variable, ensuring that generated packages are clearly identified with their target architecture (e.g., custom_opp_Linux_x86_64.run).
  • Streamlined Build Script: The build.sh script has been simplified by removing several hardcoded environment variable definitions related to ASCEND_CANN_PACKAGE_PATH and CPATH, likely deferring these configurations to CMake.
  • Dynamic Include Paths: Include directories in op_host/CMakeLists.txt now utilize the CANN_HOST_ARCH variable, making the paths dynamic and adaptable to different host architectures rather than being hardcoded to aarch64-linux.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adapts the build process for x86_64 architecture. The changes include modifications to CMakeLists.txt, CMakePresets.json, build.sh, and op_host/CMakeLists.txt to handle different architectures and streamline the build process. The cross-compilation logic has been removed, and the package file name now includes the architecture. The review focuses on ensuring the correctness of the architecture-specific configurations and the removal of unnecessary code.

@iforgetmyname iforgetmyname merged commit 7100dd7 into sgl-project:main Oct 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants