-
Notifications
You must be signed in to change notification settings - Fork 17
[WIP] feat: upgrade jax version to v0.7.2 #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Prayer3th, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the JAX library to version 0.7.2. This involves updating the project's dependency configuration and adapting the codebase to reflect changes in the JAX sharding API, ensuring compatibility and leveraging the latest features and improvements from the new JAX version. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the JAX dependency to version ~=0.7.2
. The change includes updating pyproject.toml
and modifying sgl_jax/srt/model_executor/model_runner.py
to use jax.sharding.set_mesh
, which is the correct API for the new JAX version, replacing the deprecated jax.sharding.use_mesh
. The related obsolete comments have been cleaned up as well. The changes are correct and well-contained. I have no further suggestions.
@JamesBrianD Can you fix the CI? We need to upgrade the Python version to 3.12. |
This issue has been resolved, and CI is functioning normally. |
Maybe we should do more evaluation before updating to v0.7.2? It has been reported to have some issues in our daily meeting. |
Tunix appears to depend on a newer version of JAX. We will evaluate whether an upgrade is necessary and will not merge this PR immediately. |
https://github.com/jax-ml/jax/releases/tag/jax-v0.7.2