Skip to content

Conversation

Prayer3th
Copy link
Collaborator

@Prayer3th Prayer3th commented Oct 10, 2025

Copy link

Summary of Changes

Hello @Prayer3th, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the JAX library to version 0.7.2. This involves updating the project's dependency configuration and adapting the codebase to reflect changes in the JAX sharding API, ensuring compatibility and leveraging the latest features and improvements from the new JAX version.

Highlights

  • JAX Version Upgrade: The JAX dependency has been updated from version "0.6.2" to "0.7.2" in the pyproject.toml file.
  • JAX Sharding API Update: The jax.sharding.use_mesh API call has been replaced with jax.sharding.set_mesh in model_runner.py to align with the updated JAX version's API changes for mesh handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the JAX dependency to version ~=0.7.2. The change includes updating pyproject.toml and modifying sgl_jax/srt/model_executor/model_runner.py to use jax.sharding.set_mesh, which is the correct API for the new JAX version, replacing the deprecated jax.sharding.use_mesh. The related obsolete comments have been cleaned up as well. The changes are correct and well-contained. I have no further suggestions.

@Prayer3th
Copy link
Collaborator Author

@JamesBrianD Can you fix the CI? We need to upgrade the Python version to 3.12.

@JamesBrianD
Copy link
Collaborator

@JamesBrianD Can you fix the CI? We need to upgrade the Python version to 3.12.

This issue has been resolved, and CI is functioning normally.

@chhzh123
Copy link
Collaborator

Maybe we should do more evaluation before updating to v0.7.2? It has been reported to have some issues in our daily meeting.

@JamesBrianD
Copy link
Collaborator

Maybe we should do more evaluation before updating to v0.7.2? It has been reported to have some issues in our daily meeting.

Tunix appears to depend on a newer version of JAX. We will evaluate whether an upgrade is necessary and will not merge this PR immediately.

@Prayer3th Prayer3th closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants