Skip to content

Conversation

@chhzh123
Copy link
Collaborator

This PR enables ruff checking to all files, which can potentially detect typing issues at the beginning

@gemini-code-assist
Copy link

Summary of Changes

Hello @chhzh123, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the codebase's quality and maintainability by integrating the ruff linter for comprehensive code analysis. This integration led to a substantial cleanup effort, removing unused imports, standardizing string formatting, and refining exception handling across many files. Additionally, a new configuration file (config.yaml) has been introduced, likely to streamline resource provisioning and setup for CI/CD pipelines or deployment environments, particularly for TPU-based operations.

Highlights

  • Code Quality Enhancement: Integrated ruff linter checks across the entire codebase by modifying .pre-commit-config.yaml to include the python/ directory and adding the F821 rule (undefined name) to detect potential typing issues and other code quality problems.
  • Code Cleanup and Refactoring: Performed extensive code cleanup by removing numerous unused imports (e.g., subprocess, defaultdict, Any, Union, partial, Mesh, NamedSharding, LoadFormat, ModelWorkerBatch, SamplingBatchInfo, ForwardMode, RotaryEmbedding, LogitsProcessorOutput, get_abstract_mesh, mesh_lib, Mock, tqdm, copy, ModelRunner, shutil, jax.numpy as jnp, Set, os, subprocess, io, psutil, pybase64, requests, zmq, PIL.Image) and converting f-strings to regular strings in various print and logger.info statements, likely as a result of the new ruff checks.
  • New Configuration File: Added a new config.yaml file, which appears to define resource allocation and setup commands, specifically for TPU environments and SSH key management, indicating potential new CI/CD or deployment configurations.
  • Test Utilities Update: Updated test utility files (run_jax_loader_test.py, run_qwen3_moe_test.py, run_qwen_test.py) to use importlib.util.find_spec for dependency checks instead of direct imports, and replaced unittest with importlib in some cases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@JamesBrianD
Copy link
Collaborator

The project.toml file requires additional configuration.

[tool.ruff.lint]
select = ["E", "F", "UP", "B", "SIM", "I", "G"]
ignore = ["F405", "F403", "E402", "E501", "B905","B007","UP032"]

[tool.ruff.format]
docstring-code-format = true

After executing pre-commit run --all-files --show-diff-on-failure, manual modifications are still required to resolve issues with unused f-strings and local variables in the code.

@chhzh123 chhzh123 force-pushed the ruff_all branch 2 times, most recently from b2414fd to 3e4cc5c Compare October 18, 2025 01:48
@chhzh123
Copy link
Collaborator Author

@JamesBrianD @Prayer3th It seems the CI crashed after upgrading the JAX version

@chhzh123
Copy link
Collaborator Author

@JamesBrianD Could you help review again and merge? Thanks!

Copy link
Collaborator

@Prayer3th Prayer3th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prayer3th
Copy link
Collaborator

Will be merged when CI passed

@Prayer3th Prayer3th merged commit 79c4a1e into main Oct 20, 2025
4 checks passed
@Prayer3th Prayer3th deleted the ruff_all branch October 20, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants