Cleanup CI #147
Open
Cleanup CI #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizhangNV
reviewed
Jun 12, 2025
| @@ -19,48 +19,14 @@ jobs: | |||
| - name: Checkout | |||
| uses: actions/checkout@v4 | |||
|
|
|||
There was a problem hiding this comment.
I'm trying to understand what exactly this workflow is doing.
Is this workflow only ran when user manually trigger it? If that is the case, do we really need to Upload export artifact step? Are any other jobs using the artifacts? Or it's just for people to download the artifacts?
There was a problem hiding this comment.
The workflow is designed so that people can get development dependencies without building them on their local computer. I put this as the recommended way to do it due to me having many problems trying to locally build the dependencies when I was starting development. It is only run when users trigger it, and the uploaded artifacts are only for them.
kaizhangNV
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #146
Reduces code duplication in workflows.