Skip to content

Draft: Reenabling bool tests #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

tdavidovicNV
Copy link
Contributor

  • Fixed a bug where call to _set_array would get type from reflection rather than ndarray
  • Removed unnecessary striding in _set_matrix in BufferElementCursor.
  • Added float4x3 tests to test_buffer_cursor
  • Added faster memcpy codepath to shader_cursor when src and dst layout matches.
  • Removed get_scalar_type_size as type sizes and strides need are not static (need to rely on reflection system anyway).
  • Added handling for setting scalars, vectors and arrays of bools based on the backend reflection types.
  • Added tests for bool2 buffers.
  • Enabled bool cursor tests for CUDA and Metal.
  • Added workaround for Slang CUDA-backend issue Reflection system misreports boolX layout on CUDA slang#7441
  • Added tests for bool2 reflection data, to catch when Reflection system misreports boolX layout on CUDA slang#7441 is resolved.

@tdavidovicNV
Copy link
Contributor Author

This cannot be re-enabled in the current state, due to the CUDA backend having unpredictable behaviors.
See the comment about buffer layouts here: shader-slang/slang#7441 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant