Skip to content

Implement BufferAtomicFCmpSwap #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement BufferAtomicFCmpSwap #3351

wants to merge 2 commits into from
+40 −0

Conversation

kalaposfos13
Copy link
Member

Used by Knack 2.
#496 (comment)

squidbus
squidbus reviewed Jul 30, 2025
View reviewed changes
src/shader_recompiler/backend/spirv/emit_spirv_atomic.cpp
Id (Sirit::Module::*atomic_func)(Id, Id, Id, Id, Id, Id, Id)) {
const auto& buffer = ctx.buffers[handle];
if (const Id offset = buffer.Offset(PointerSize::B32); Sirit::ValidId(offset)) {
address = ctx.OpIAdd(ctx.F32[1], address, offset);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address is not F32

@squidbus
Copy link
Collaborator

According to the spec, OpAtomicCompareExchange only accepts integers so I don't think this will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidbus squidbus squidbus left review comments

+1 more reviewer

@mikusp mikusp mikusp left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalaposfos13 @squidbus @mikusp