[Draft] Use native file handlers #3368
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed streams, files are handled by native file descriptor (Linux only) * Removed FileType - unnecessary, native handlers don't divide text/binary * Divided io_file.cpp between linux/posix and windows, selected upon compiling (reduce mess in source files) * Files canm be accessed without changes (FileAccessMode) - target behaviour preserved, added option to truncate files on writing (Write/WriteExtended) * Minor commenting and documentation * Checks, modified flow of open() in file_system.cpp
* Removed streams, files are handled by native file descriptor (Linux only) * Removed FileType - unnecessary, native handlers don't divide text/binary * Divided io_file.cpp between linux/posix and windows, selected upon compiling (reduce mess in source files) * Files canm be accessed without changes (FileAccessMode) - target behaviour preserved, added option to truncate files on writing (Write/WriteExtended) * Minor commenting and documentation * Checks, modified flow of open() in file_system.cpp
File permissions are passed on posix_open
Platform-specific binds moved to separate namespace
Doesn't compile, I need a break
StevenMiller123
requested changes
Aug 22, 2025
Corrected namespaces IOFile IsOpen quits earlier if fd==-1 Removed misleading/redundant comments
Added NativeFS::Touch() Translated all POSIX errors to Orbis
R/W returning s64 (signed), not size_t (unsigned)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how IOFile is handled on OS-level.
Improves compatibility and granularity with Orbis file-related kernel calls.
Existing (in-app call) behaviour and usage is not affected (I think).
Currently implemented for UNIX (POSIX calls).
Windows implementation pending.
Further tests are needed to confirm correct operation.
Subject to changes.