fix linting errors for CI

Author: Judahmeek

client/app/bundles/comments/startup/NavigationBarApp.jsx

@@ -14,7 +14,7 @@ import * as paths from '../constants/paths';
  *  This is used for the client rendering hook after the page html is rendered.
  *  React will see that the state is the same and not do anything.
  */
-function NavigationBarApp(_props, railsContext) {
+function NavigationBarAppFactory(_props, railsContext) {
   // This is where we get the existing store.
   const { pathname } = railsContext;
   let store;
@@ -23,16 +23,20 @@ function NavigationBarApp(_props, railsContext) {
   } else if (pathname === paths.NO_ROUTER_PATH) {
     store = ReactOnRails.getStore('commentsStore', false);
   } else {
-    return () => <NavigationBar {...{ pathname }} />;
+    return function NavigationBarApp() {
+      return <NavigationBar {...{ pathname }} />;
+    };
   }
 
   // eslint interprets the return as a new component definition, which is not the case
   // eslint-disable-next-line react/display-name, react/no-unstable-nested-components
-  return () => (
-    <Provider store={store}>
-      <NavigationBarContainer />
-    </Provider>
-  );
+  return function NavigationBarApp() {
+    return (
+      <Provider store={store}>
+        <NavigationBarContainer />
+      </Provider>
+    );
+  };
 }
 
-export default NavigationBarApp;
+export default NavigationBarAppFactory;

client/app/bundles/comments/startup/ServerRouterApp.jsx

@@ -25,13 +25,15 @@ function ServerRouterApp(_props, railsContext) {
 
   // Important that you don't do this if you are redirecting or have an error.
   // eslint-disable-next-line react/display-name
-  return () => (
-    <Provider store={store}>
-      <StaticRouter location={location} context={context}>
-        {routes}
-      </StaticRouter>
-    </Provider>
-  );
+  return function ServerRouter() {
+    return (
+      <Provider store={store}>
+        <StaticRouter location={location} context={context}>
+          {routes}
+        </StaticRouter>
+      </Provider>
+    );
+  };
 }
 
 export default ServerRouterApp;

client/app/packs/client-bundle.js

@@ -1,5 +1,6 @@
 import ReactOnRails from 'react-on-rails';
 import 'bootstrap-loader';
+// eslint-disable-next-line import/no-webpack-loader-syntax
 import 'expose-loader?exposes=$,jQuery!jquery';
 import 'jquery-ujs';