added support for sparse matrices #424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Owner
|
Closing in favor of PR #532 which provides a more comprehensive approach to sparse matrix support. This PR (#424) from 2023 attempted sparse matrix support with a While this PR had the right idea, #532 is more recent and handles the problem more elegantly by automatically detecting sparse matrices rather than requiring a manual parameter. If #532 doesn't get merged after review, we can revisit this approach. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "should_preprocess" bool parameter to the
fitfunction, making it easy to turn off the mechanisms that don't work with sparse matrices.