Skip to content

fixed speedrun site support #2288 #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2024
Merged

fixed speedrun site support #2288 #2291

merged 2 commits into from
Nov 1, 2024

Conversation

Suramyavns
Copy link
Contributor

No description provided.

@Suramyavns Suramyavns mentioned this pull request Sep 10, 2024
Open
1 task
@ppfeister
Copy link
Member

This PR seems to duplicate Speedrun, and with two different detection methods. Safe to say that this is unintentional?

PS - The addition of username_unclaimed is going to make this fail schema validation.

@Suramyavns
Copy link
Contributor Author

I removed the duplication of speedrun and fixed the error checking in the existing site data for speedrun

@Suramyavns
Copy link
Contributor Author

Suramyavns commented Sep 12, 2024 •
edited
Loading

hey @ppfeister
this is one of my first FOSS contributions I just wanted to know if my PR would be merged soon

@ppfeister
Copy link
Member

Busy week is all. Schema wise it's good now, I've just gotta validate the check when I have a moment. Won't be long though as long as it checks out 👍

@Suramyavns
Copy link
Contributor Author

Busy week is all. Schema wise it's good now, I've just gotta validate the check when I have a moment. Won't be long though as long as it checks out 👍

hey merge it now maybe?

@YuvamGupta
Copy link

@ppfeister please merge it now

ppfeister
ppfeister approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@ppfeister ppfeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Appreciate the fix and the conversion back to status_code (more consistent across regions)
Merging into master

@ppfeister ppfeister merged commit c64e795 into sherlock-project:master Nov 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppfeister ppfeister ppfeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Suramyavns @ppfeister @YuvamGupta