Skip to content

Updated ReadMe and added Udemy and DailyDev #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Updated ReadMe and added Udemy and DailyDev #2331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47f6707
Added Udemy, DailyDev
NJWasTaken Oct 14, 2024
526047b
Updated README.md
NJWasTaken Oct 14, 2024
9419b74
Update README.md
NJWasTaken Oct 14, 2024
865cac9
Merge branch 'sherlock-project:master' into master
NJWasTaken Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ optional arguments:
--nsfw Include checking of NSFW sites from default list.
```

In case installation fails:
```bash
python -m sherlock_project user1 user2 user3
```
or
```bash
python3 -m sherlock_project user1 user2 user3
```
Comment on lines +99 to +106
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain this section please?

Python's gotta get it from somewhere, and that would presumably be by installation (which either failed or didn't)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure why only this method works for me, but I'm guessing even if the installation is somewhat successful, running it by directly calling the module with Python bypasses permission or setup issues.

## Credits

Thank you to everyone who has contributed to Sherlock! ❤️
Expand Down
14 changes: 14 additions & 0 deletions sherlock_project/resources/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,13 @@
"urlMain": "https://www.dailymotion.com/",
"username_claimed": "blue"
},
"DailyDev":{
"errorType": "message",
"errorMsg":"Page not found.",
"url": "https://app.daily.dev/{}",
"urlMain": "https://app.daily.dev/",
"username_claimed": "nj05"
},
Comment on lines +630 to +636
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns positive for all queries
errorType of message should be a last resort behind status_code due to l10n issues

"Dealabs": {
"errorMsg": "La page que vous essayez",
"errorType": "message",
Expand Down Expand Up @@ -2834,6 +2841,13 @@
"urlMain": "https://www.toster.ru/",
"username_claimed": "adam"
},
"udemy": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please capitalize for UX (minor bikeshed maybe)

"errorMsg": "Page not found",
"errorType": "message",
"url":"https://www.udemy.com/user/{}",
"urlMain": "https://www.udemy.com/",
"username_claimed": "adfadf"
},
Comment on lines +2844 to +2850
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns positive for all queries
errorType of message should be a last resort behind status_code due to l10n issues

"uid": {
"errorType": "status_code",
"url": "http://uid.me/{}",
Expand Down