Skip to content

Conversation

purifetchi
Copy link
Member

No description provided.

@mary-ext
Copy link
Contributor

mary-ext commented Dec 29, 2024

I think you can shorten a lot of these field names since the object names already makes it clear what it's about, e.g. oekakiRecordKey to recordKey/rkey.

I'd probably recommend only returning an AT-URI rather than both (though it does come at the expense of having to fish it out every time you need it for something).

but if you're going this route, you should probably set the string's format to record-key, I don't remember if the JSON schema has it.

@purifetchi
Copy link
Member Author

@mary-ext applied your hints about shortening the names of some of the field names. could you check and say whether they look alright or not?

@mary-ext
Copy link
Contributor

mary-ext commented Jan 3, 2025

sgtm, could move the did and handle field to an author object so you can extend more on it later on

@purifetchi purifetchi force-pushed the lexicons branch 2 times, most recently from a063aca to 39fe035 Compare January 4, 2025 13:34
@purifetchi purifetchi force-pushed the lexicons branch 2 times, most recently from 64a50e0 to 4d8c0db Compare January 4, 2025 13:40
@purifetchi purifetchi merged commit 1f8d960 into master Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants