#5876 Switched file decryption priority to be original file extension #5988
Conversation
… type or its file extension. (cherry picked from commit d48965b1d327210771873ac44999edcb6e0ef69c)
|
Thank you very much for looking into this @MarlowBrown |
|
Hey @tomduese. Since I'm just a contributor to this repository it will be when one of the signal devs takes a look at it to merge it into the codebase. Depending on how busy their day is I can't give you a concrete timeline. All that I hope for is within a month. |
|
Hey @MarlowBrown. This is a deceptively simple change, and before we take it I'll need to do a thorough evaluation of what the upstream effects would be. This method is very explicit in its preference order, so while it may be safe to change this I'd want to be sure it won't inadvertently break other things. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Keep open
…On Tue, Jul 8, 2025 at 7:27 AM github-actions[bot] ***@***.***> wrote:
*github-actions[bot]* left a comment (signalapp/Signal-iOS#5988)
<#5988 (comment)>
This PR has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
—
Reply to this email directly, view it on GitHub
<#5988 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI3H5DKUEDWC6FXI3NKUDK33HO2KFAVCNFSM6AAAAABX7AXH6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANBYG42DIMZWGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Keep open
…On Wed, Oct 8, 2025 at 7:27 AM github-actions[bot] ***@***.***> wrote:
*github-actions[bot]* left a comment (signalapp/Signal-iOS#5988)
<#5988 (comment)>
This PR has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
—
Reply to this email directly, view it on GitHub
<#5988 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI3H5DOF5JNHC2SFJTWFIFL3WT7KLAVCNFSM6AAAAABX7AXH6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOBRGI3TSOBVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor checklist
Description
This PR
fixes #5876by changing the file decryption priority to be the files original extension instead of the detected files mime type.However I do see some value in decrypting the file as its mime type to see the raw file; I think losing the ability to send the file to the respective application its used for comes second to that. Perhaps in the future the UI/UX will be redesigned to accommodate path viewing the raw file and being able to use the original files extension.
FPLSignal.mov