Skip to content

Add timestamp client and verifier #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Conversation

aaronlew02
Copy link
Collaborator

Signed-off-by: Aaron Lew 64337293+aaronlew02@users.noreply.github.com

Closes: #958

Summary

Add a TimestampClient to request a timestamp from a timestamp authority and a TimestampVerifier to verify a timestamp.

@aaronlew02 aaronlew02 force-pushed the timestamp-client-verifier branch 4 times, most recently from 7201095 to 52de8bd Compare May 14, 2025 20:07
Copy link
Collaborator

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great work! I can't speak much to Java style, I'll let Appu chime in there.

Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some preliminary comments, I'll go over the logic in TimestampClientHttp on a second pass.

@aaronlew02 aaronlew02 force-pushed the timestamp-client-verifier branch 4 times, most recently from ce3d63d to 2eaaa55 Compare May 16, 2025 22:47
Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some minor things

Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
@aaronlew02 aaronlew02 force-pushed the timestamp-client-verifier branch from 2eaaa55 to 011ce8f Compare May 19, 2025 14:44
@aaronlew02 aaronlew02 requested a review from loosebazooka May 19, 2025 17:58
Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@aaronlew02 aaronlew02 merged commit 5e4585d into main May 19, 2025
26 checks passed
@aaronlew02 aaronlew02 deleted the timestamp-client-verifier branch May 19, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timestamp client and verifier
3 participants