-
Notifications
You must be signed in to change notification settings - Fork 23
Add timestamp client and verifier #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7201095
to
52de8bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great work! I can't speak much to Java style, I'll let Appu chime in there.
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClient.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClientHttp.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClientHttp.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampResponse.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampVerifier.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampVerifier.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some preliminary comments, I'll go over the logic in TimestampClientHttp on a second pass.
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClient.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClient.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClientHttp.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampClientHttp.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampRequest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampRequest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/test/java/dev/sigstore/timestamp/client/TimestampClientHttpTest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/timestamp/client/TimestampRequest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/test/java/dev/sigstore/timestamp/client/TimestampClientHttpTest.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/test/java/dev/sigstore/timestamp/client/TimestampVerifierTest.java
Outdated
Show resolved
Hide resolved
ce3d63d
to
2eaaa55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some minor things
sigstore-java/src/main/java/dev/sigstore/trustroot/SigstoreTrustedRoot.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/trustroot/SigstoreTrustedRoot.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
2eaaa55
to
011ce8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
Signed-off-by: Aaron Lew 64337293+aaronlew02@users.noreply.github.com
Closes: #958
Summary
Add a
TimestampClient
to request a timestamp from a timestamp authority and aTimestampVerifier
to verify a timestamp.