Skip to content

Update Examples action to run on Windows, MacOs, and Linux #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 30, 2025

Conversation

keastrid
Copy link
Contributor

Summary

Demonstration of #973 and testing to make sure it won't occur again by running in CI

Release Note

NONE

Documentation

No documentation changes needed

keastrid added 5 commits May 28, 2025 13:53
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
@loosebazooka
Copy link
Member

Okay, I think I found the issue, if you update this PR with

diff --git a/sigstore-java/src/main/java/dev/sigstore/encryption/certificates/Certificates.java b/sigstore-java/src/main/java/dev/sigstore/encryption/certificates/Certificates.java
index 9308efd..9cf75c7 100644
--- a/sigstore-java/src/main/java/dev/sigstore/encryption/certificates/Certificates.java
+++ b/sigstore-java/src/main/java/dev/sigstore/encryption/certificates/Certificates.java
@@ -48,7 +48,7 @@ public class Certificates {
       pemWriter.writeObject(cert);
       pemWriter.flush();
     }
-    return certWriter.toString();
+    return certWriter.toString().replaceAll("\r\n", "\n");
   }

   /** Convert a certificate to a PEM encoded certificate. */
@@ -94,7 +94,7 @@ public class Certificates {
       }
       pemWriter.flush();
     }
-    return certWriter.toString();
+    return certWriter.toString().replaceAll("\r\n", "\n");
   }

essentially stripping out the \r everywhere on PEM write, then we'll pass

Signed-off-by: keastrid <70925169+keastrid@users.noreply.github.com>
@keastrid
Copy link
Contributor Author

@loosebazooka
Copy link
Member

loosebazooka commented May 29, 2025

Yeah that's against the latest release. It's fine. If you comment out the release build for Windows you can see it pass on the dev build. But I would leave it in. We can probably think about publishing a fixed version soon

@loosebazooka
Copy link
Member

thanks for this @keastrid

@loosebazooka loosebazooka merged commit c58a351 into sigstore:main May 30, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants