Basic dark mode improvements. #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhamp
reviewed
Jul 24, 2023
| "license": "MIT", | ||
| "require": { | ||
| "php": "^8.1", | ||
| "filament/filament": "^3.0", |
Contributor
Author
There was a problem hiding this comment.
Nope this was a mistake, was playing with that in a different dir and must have ran it here too 🤦🏻
Comment on lines
-19
to
+20
| <img src="/cronikl.svg" class="w-64 mb-8 pointer-events-none select-none" /> | ||
| <img src="/cronikl.svg" class="w-64 mb-8 pointer-events-none select-none block dark:hidden" /> | ||
| <img src="/cronikl-white.svg" class="w-64 mb-8 pointer-events-none select-none hidden dark:block" /> |
Owner
There was a problem hiding this comment.
This will do for now, but...
If the one SVG could be coloured with the fill: classes, that would even nicer than having to swap 2 separate image files' visibility
Contributor
Author
There was a problem hiding this comment.
Yepyepyep agreed, will sort that at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few basic dark mode improvements including a white logo and base text colours.