valuation: don't let future P directives influence default valuation/end date #2449
+115
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmichael
added
needs-discussion
simonmichael
force-pushed
the
sm-valuation-date
branch
from
ca96817 to
f4d2613
Compare
…/valuation date [#2445] In end-value reports with unspecified end date, a market price later than the latest transaction can extend the default report end date and valuation date. Now, only market prices on or before "today" can do this; market price declarations dated in the future will be ignored. Report span and valuation date calculations have been clarified.
simonmichael
force-pushed
the
sm-valuation-date
branch
from
f4d2613 to
17707cc
Compare
|
After several attempts, I have pushed a new fix that implements just the change described above, while seemingly not changing old behaviour otherwise. This is a confusing rabbit hole, but I think this is the right fix. |
simonmichael
removed
needs-discussion
simonmichael
changed the title
simonmichael
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #2445.
Previously, for end-value reports, a P directive later than the latest transaction could set the default report end date and valuation date - even if that P directive was in the future.
Now, future-dated P directives are ignored; only non-future P directives can influence valuation date.
The PR also tries to clarify report span calculation, and various related functions.
The changes to tests show that the P directives can also extend the report end date, which seems to be new behaviour. I'm not sure if the old or new behaviour is more correct/intuitive/straightforward, so this needs some review and discussion.